Reduce global memory size for sub devices

Related-To: NEO-4484
Change-Id: I6822ceedddde03353d6a2c6b2234f31d91fd9efe
Signed-off-by: Mateusz Jablonski <[email protected]>

Author: JablonskiMateusz

opencl/test/unit_test/device/sub_device_tests.cpp

@@ -10,6 +10,7 @@
 #include "shared/test/unit_test/helpers/debug_manager_state_restore.h"
 #include "shared/test/unit_test/helpers/ult_hw_config.h"
 #include "shared/test/unit_test/helpers/variable_backup.h"
+#include "shared/test/unit_test/mocks/ult_device_factory.h"
 
 #include "opencl/source/cl_device/cl_device.h"
 #include "opencl/test/unit_test/mocks/mock_cl_device.h"
@@ -249,3 +250,15 @@ TEST(RootDevicesTest, givenRootDeviceWithSubdevicesWhenCreateEnginesThenDeviceCr
     device.createEngines();
     EXPECT_EQ(1u, device.engines.size());
 }
+
+TEST(SubDevicesTest, givenRootDeviceWithSubDevicesWhenGettingGlobalMemorySizeThenSubDevicesReturnReducedAmountOfGlobalMemAllocSize) {
+    const uint32_t numSubDevices = 2u;
+    UltDeviceFactory deviceFactory{1, numSubDevices};
+
+    auto totalGlobalMemorySize = deviceFactory.rootDevices[0]->getGlobalMemorySize();
+    auto expectedGlobalMemorySize = totalGlobalMemorySize / numSubDevices;
+
+    for (const auto &subDevice : deviceFactory.subDevices) {
+        EXPECT_EQ(expectedGlobalMemorySize, static_cast<MockSubDevice *>(subDevice)->getGlobalMemorySize());
+    }
+}

shared/source/device/device.cpp

@@ -227,4 +227,14 @@ GmmClientContext *Device::getGmmClientContext() const {
     return getGmmHelper()->getClientContext();
 }
 
+uint64_t Device::getGlobalMemorySize() const {
+
+    auto globalMemorySize = getMemoryManager()->isLocalMemorySupported(this->getRootDeviceIndex())
+                                ? getMemoryManager()->getLocalMemorySize(this->getRootDeviceIndex())
+                                : getMemoryManager()->getSystemSharedMemory(this->getRootDeviceIndex());
+    globalMemorySize = std::min(globalMemorySize, getMemoryManager()->getMaxApplicationAddress() + 1);
+    globalMemorySize = static_cast<uint64_t>(static_cast<double>(globalMemorySize) * 0.8);
+    return globalMemorySize;
+}
+
 } // namespace NEO

shared/source/device/device.h

@@ -103,6 +103,7 @@ class Device : public ReferenceTrackedObject<Device> {
     virtual bool createEngines();
     bool createEngine(uint32_t deviceCsrIndex, aub_stream::EngineType engineType);
     MOCKABLE_VIRTUAL std::unique_ptr<CommandStreamReceiver> createCommandStreamReceiver() const;
+    virtual uint64_t getGlobalMemorySize() const;
 
     DeviceInfo deviceInfo = {};
 

shared/source/device/device_caps.cpp

@@ -50,11 +50,7 @@ void Device::initializeCaps() {
 
     deviceInfo.globalMemCachelineSize = 64;
 
-    deviceInfo.globalMemSize = getMemoryManager()->isLocalMemorySupported(this->getRootDeviceIndex())
-                                   ? getMemoryManager()->getLocalMemorySize(this->getRootDeviceIndex())
-                                   : getMemoryManager()->getSystemSharedMemory(this->getRootDeviceIndex());
-    deviceInfo.globalMemSize = std::min(deviceInfo.globalMemSize, getMemoryManager()->getMaxApplicationAddress() + 1);
-    deviceInfo.globalMemSize = static_cast<uint64_t>(static_cast<double>(deviceInfo.globalMemSize) * 0.8);
+    deviceInfo.globalMemSize = getGlobalMemorySize();
 
     if (DebugManager.flags.Force32bitAddressing.get() || addressing32bitAllowed || is32bit) {
         deviceInfo.globalMemSize = std::min(deviceInfo.globalMemSize, static_cast<uint64_t>(4 * GB * 0.8));

shared/source/device/sub_device.cpp

@@ -43,4 +43,9 @@ Device *SubDevice::getDeviceById(uint32_t deviceId) const {
     return const_cast<SubDevice *>(this);
 }
 
+uint64_t SubDevice::getGlobalMemorySize() const {
+    auto globalMemorySize = Device::getGlobalMemorySize();
+    return globalMemorySize / rootDevice.getNumAvailableDevices();
+}
+
 } // namespace NEO

shared/source/device/sub_device.h

@@ -24,6 +24,7 @@ class SubDevice : public Device {
 
   protected:
     DeviceBitfield getDeviceBitfield() const override;
+    uint64_t getGlobalMemorySize() const override;
     const uint32_t subDeviceIndex;
     RootDevice &rootDevice;
 };

shared/test/unit_test/mocks/mock_device.h

@@ -26,6 +26,7 @@ class UltCommandStreamReceiver;
 extern CommandStreamReceiver *createCommandStream(ExecutionEnvironment &executionEnvironment, uint32_t rootDeviceIndex);
 
 struct MockSubDevice : public SubDevice {
+    using SubDevice::getGlobalMemorySize;
     using SubDevice::SubDevice;
 
     std::unique_ptr<CommandStreamReceiver> createCommandStreamReceiver() const override {
@@ -42,6 +43,7 @@ class MockDevice : public RootDevice {
     using Device::deviceInfo;
     using Device::engines;
     using Device::executionEnvironment;
+    using Device::getGlobalMemorySize;
     using Device::initializeCaps;
     using RootDevice::createEngines;
     using RootDevice::subdevices;