Skip to content

Commit 1479afd

Browse files
committed
Align behavior with CUDA/HIP: skip test_matmul when swiglu_opts is not None and do_gamma is set
Signed-off-by: Witold Dziurdz <[email protected]>
1 parent c6681ec commit 1479afd

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

python/triton_kernels/tests/test_matmul.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# testing utilities
1717
from triton_kernels.testing import assert_close, make_random_tensor
1818
# target-specific utilities
19-
from triton_kernels.target_info import is_hip, is_hip_cdna3, is_cuda, is_hip_cdna4
19+
from triton_kernels.target_info import is_hip, is_hip_cdna3, is_cuda, is_hip_cdna4, is_xpu
2020
from triton_kernels.swiglu import swiglu, swiglu_fn
2121
from triton_kernels.swiglu import PrecisionConfig as SwiGLUPrecisionConfig
2222

@@ -243,6 +243,10 @@ def _test_op(m, n, k, split_k, do_gather, do_scatter, inner_expt_opt, do_gamma,
243243
if split_k is not None and split_k > 1:
244244
pytest.skip("splitK hasn't been fully tested on AMD GPU.")
245245

246+
elif is_xpu():
247+
if swiglu_opts is not None and do_gamma:
248+
pytest.xfail("NYI: swiglu and gamma not supported together")
249+
246250
if "float8_e4m3fnuz" in (weight_dtype_str, act_dtype_str) and not is_hip_cdna3():
247251
pytest.xfail("float8_e4m3fnuz only tested on AMD CDNA3 Platform")
248252

0 commit comments

Comments
 (0)