Skip to content

[UR] Update SetErrorMessage implementations to have correct type for ErrorCode param #18260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martygrant opened this issue Apr 30, 2025 · 0 comments · Fixed by #18264
Closed
Assignees

Comments

@martygrant
Copy link
Contributor

martygrant commented Apr 30, 2025

As discussed in #18182 (comment) the common function SetErrorMessage which is used to set the message retrieved when using the urAdapterGetLastError entry point is expecting a ur_result_t for the ErrorCode param but should instead be int32_t, this occurs in most adapter implementations.

@martygrant martygrant self-assigned this Apr 30, 2025
@martygrant martygrant changed the title [UR] Update urAdapterGetLastError implementations to have correct type for pError param [UR] Update SetErrorMessage implementations to have correct type for pError param Apr 30, 2025
@martygrant martygrant changed the title [UR] Update SetErrorMessage implementations to have correct type for pError param [UR] Update SetErrorMessage implementations to have correct type for ErrorCode param Apr 30, 2025
martygrant added a commit that referenced this issue May 7, 2025
…_t for the urAdapterGetLastError entry point (#18264)

Fixes #18260

Also updates `checkUrResult` in SYCL RT to remove warning level check as
`urAdapterGetLastError` is now only used for errors.

---------

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
github-actions bot pushed a commit to oneapi-src/unified-runtime that referenced this issue May 8, 2025
…urAdapterGetLastError entry point (#18264)

Fixes intel/llvm#18260

Also updates `checkUrResult` in SYCL RT to remove warning level check as
`urAdapterGetLastError` is now only used for errors.

---------

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
kbenzie added a commit to oneapi-src/unified-runtime that referenced this issue May 8, 2025
…urAdapterGetLastError entry point (#18264)

Fixes intel/llvm#18260

Also updates `checkUrResult` in SYCL RT to remove warning level check as
`urAdapterGetLastError` is now only used for errors.

---------

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants