You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, that applies it globally and we can't realistically expect LLVM to build with this flag. Therefore, as part of this task, I suggest that we drop -Wconversion from AddSecurityFlags.cmake and apply it to specific sub-projects that we own ourselves.
Activity
-Wconversion
warnings #18786AlexeySachkov commentedon Jun 3, 2025
We kind of have it already in
llvm/llvm/cmake/modules/AddSecurityFlags.cmake
Line 71 in 6bcb265
However, that applies it globally and we can't realistically expect LLVM to build with this flag. Therefore, as part of this task, I suggest that we drop
-Wconversion
fromAddSecurityFlags.cmake
and apply it to specific sub-projects that we own ourselves.KornevNikita commentedon Jun 3, 2025
@uditagarwal97 I guess it's easy to find the right place, but just in case it probably should be here - https://github.com/intel/llvm/blob/sycl/sycl/CMakeLists.txt#L107
Also, it would be nice to have "-Wimplicit-fallthrough" for release builds, this flag is also a part of requirements (but only for the release type).