chore(tests): add more tests for data collection

Author: Umaaz

.idea/kubernetes-settings.xml

@@ -151,7 +151,7 @@ public String id() {
 
   @Override
   public boolean isEnabled() {
-    return this.settings.getSettingAs(ISettings.KEY_ENABLED, Boolean.class);
+    return this.settings.isActive();
   }
 
   @Override

agent/src/main/java/com/intergral/deep/agent/DeepAgent.java

@@ -135,12 +135,12 @@ private static Iterable<? extends StackFrame> convertFrames(
     }).collect(Collectors.toList());
   }
 
-  private static Iterable<? extends com.intergral.deep.proto.tracepoint.v1.VariableID> covertVariables(
+  public static Collection<com.intergral.deep.proto.tracepoint.v1.VariableID> covertVariables(
       final Collection<VariableID> frameVariables) {
     return frameVariables.stream().map(PushUtils::convertVariableID).collect(Collectors.toList());
   }
 
-  private static Map<String, Variable> convertVarLookup(
+  public static Map<String, Variable> convertVarLookup(
       final Map<String, com.intergral.deep.agent.types.snapshot.Variable> varLookup) {
     return varLookup.entrySet()
         .stream()

agent/src/main/java/com/intergral/deep/agent/push/PushUtils.java

@@ -17,6 +17,7 @@
 
 package com.intergral.deep.agent.tracepoint.handler;
 
+import com.intergral.deep.agent.Utils;
 import com.intergral.deep.agent.api.plugin.IEvaluator;
 import com.intergral.deep.agent.api.resource.Resource;
 import com.intergral.deep.agent.settings.Settings;
@@ -47,7 +48,6 @@ public class FrameCollector extends VariableProcessor {
   protected final Map<String, Object> variables;
   private final StackTraceElement[] stack;
 
-  private final Map<String, String> varCache = new HashMap<>();
   private final String jspSuffix;
   private final List<String> jspPackages;
 
@@ -214,23 +214,6 @@ protected boolean processNode(final Node node) {
     return true;
   }
 
-  private boolean checkVarCount() {
-    return varCache.size() <= this.frameConfig.maxVariables();
-  }
-
-  @Override
-  protected String checkId(final String identity) {
-    return this.varCache.get(identity);
-  }
-
-  @Override
-  protected String newVarId(final String identity) {
-    final int size = this.varCache.size();
-    final String newId = String.valueOf(size + 1);
-    this.varCache.put(identity, newId);
-    return newId;
-  }
-
   protected boolean isAppFrame(final StackTraceElement stackTraceElement) {
     final List<String> inAppInclude = settings.getAsList("in.app.include");
     final List<String> inAppExclude = settings.getAsList("in.app.exclude");
@@ -255,7 +238,7 @@ private String getFileName(final StackTraceElement stackTraceElement) {
     if (stackTraceElement.getFileName() == null) {
       return InstUtils.shortClassName(stackTraceElement.getClassName());
     }
-    return stackTraceElement.getFileName();
+    return Utils.trimPrefix(stackTraceElement.getFileName(), "/");
   }
 
   protected String getMethodName(final StackTraceElement stackTraceElement,

agent/src/main/java/com/intergral/deep/agent/tracepoint/handler/FrameCollector.java

@@ -66,10 +66,7 @@ private boolean conditionPasses(final TracePointConfig tracePointConfig) {
   }
 
   public void configureSelf() {
-    for (TracePointConfig tracePointConfig : this.filteredTracepoints) {
-      this.frameConfig.process(tracePointConfig);
-    }
-    this.frameConfig.close();
+    configureSelf(this.filteredTracepoints);
   }
 
   public Collection<EventSnapshot> collect() {