Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionManager refactor #52

Open
kpsherva opened this issue Jun 4, 2020 · 0 comments
Open

SessionManager refactor #52

kpsherva opened this issue Jun 4, 2020 · 0 comments
Labels
nice-to-have refactor

Comments

@kpsherva
Copy link
Contributor

kpsherva commented Jun 4, 2020 •
edited
Loading

Review all the code that uses current_user information outside a react component and therefore needs to take information from SessionManager. If we get rid of these places then the implementation could be simplified by removing the SessionManager class

Basically review if we can access the user information only via redux state - if this is possible, then we could remove the SessionManager class, to avoid "duplication"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice-to-have refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpsherva