Skip to content

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Nov 7, 2025

Issue URL: N/A

What is the current behavior?

There is no code syntax highlighting for vue.

What is the new behavior?

  • Add the syntax highlighting for vue
  • Switched to vue for the code blocks under the Vue guide

Prism doesn't support Vue so it needs to be added as a custom language.

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-docs Ready Ready Preview Comment Nov 13, 2025 1:00am

@brandyscarney
Copy link
Member

@thetaPC Are you waiting for a guide that uses vue highlighting to be merged before we merge this?

Comment on lines +41 to +42
import { IonContent, IonPage } from '@ionic/vue';
import SubComponent from '@/components/SubComponent.vue';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were made by lint.

@thetaPC
Copy link
Contributor Author

thetaPC commented Nov 13, 2025

@brandyscarney I was still working on it. But once the checks pass then I can mark it ready.

@thetaPC thetaPC marked this pull request as ready for review November 13, 2025 16:05
@thetaPC thetaPC requested a review from a team as a code owner November 13, 2025 16:05
@thetaPC thetaPC requested a review from BenOsodrac November 13, 2025 16:05
@thetaPC thetaPC merged commit 69b13b3 into main Nov 13, 2025
4 checks passed
@thetaPC thetaPC deleted the vue-highlight branch November 13, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants