Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

restart cli preview server when root config changes #963

Closed
wants to merge 5 commits into from

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented May 24, 2023

Description of change

Use nodemon to watch for changes in the working directory docusaurus.config.js.

Installation steps

  1. Install dependencies: yarn.
  2. Clear cli files, install dependecies and build: cd cli && yarn clean && yarn && yarn build && cd ..
  3. Start the cli: yarn iota-wiki or if that didn't work yarn ./cli iota-wiki start 'path/to/test/project'
    e.g. yarn ./cli iota-wiki start 'test/module'

Links to any relevant issues

Fixes #862

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement

Change checklist

@VmMad
Copy link
Member Author

VmMad commented May 24, 2023

Comment for reviewers:

This fix only works for changes made in the root docusaurus.config.js, but will ignore any changes made into imported files, for example changing something from common/docusaurus.config.js.
If an implementation of this logic is needed, I think it would be better to address that in another issue/PR, because it might not be as simple and it also happens when you run yarn start:iota and change something from iota/docusaurus.config.js. Importing from other files is not handled right now and I don't think is a cli only problem.

@VmMad VmMad marked this pull request as draft May 25, 2023 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the cli use the most up to date config(s)
2 participants