refactor: convert version API to async/await (#2679)

Author: Alan Shaw

src/core/components/index.js

@@ -12,6 +12,7 @@ exports.init = require('./init')
 exports.ping = require('./ping')
 exports.start = require('./start')
 exports.stop = require('./stop')
+exports.version = require('./version')
 
 exports.legacy = { // TODO: these will be removed as the new API is completed
   dag: require('./dag'),

src/core/components/init.js

@@ -302,7 +302,8 @@ function createApi ({
     config: Commands.config({ repo }),
     id: Commands.id({ peerInfo }),
     init: () => { throw new AlreadyInitializedError() },
-    start
+    start,
+    version: Commands.version({ repo })
   }
 
   return api

src/core/components/start.js

@@ -144,7 +144,8 @@ function createApi ({
       ? Commands.pubsub({ libp2p })
       : () => { throw new NotEnabledError('pubsub not enabled') },
     start: () => apiManager.api,
-    stop
+    stop,
+    version: Commands.version({ repo })
   }
 
   return api

src/core/components/stop.js

@@ -102,7 +102,8 @@ function createApi ({
     id: Commands.id({ peerInfo }),
     init: () => { throw new AlreadyInitializedError() },
     start,
-    stop: () => apiManager.api
+    stop: () => apiManager.api,
+    version: Commands.version({ repo })
   }
 
   return api

src/core/components/version.js

@@ -1,17 +1,16 @@
 'use strict'
 
 const pkg = require('../../../package.json')
-const callbackify = require('callbackify')
 
 // TODO add the commit hash of the current ipfs version to the response.
-module.exports = function version (self) {
-  return callbackify(async () => {
-    const repoVersion = await self.repo.version()
+module.exports = ({ repo }) => {
+  return async function version () {
+    const repoVersion = await repo.version()
 
     return {
       version: pkg.version,
       repo: repoVersion,
       commit: ''
     }
-  })
+  }
 }