Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to set implicit default filter-addrs and filter-protocols from IPIP-484 #86

Open
lidel opened this issue Oct 30, 2024 · 0 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Member

lidel commented Oct 30, 2024

While someguy supports IPIP-484 in queries, there is no filtering by default.

It would be useful to have opt-in filtering that limits the default output, eg. to skip GraphSync results proxied from IPNI at cid.contact in deployments that will never benefit from it because clients only support Bitswap or HTTP.

Ref. https://specs.ipfs.tech/ipips/ipip-0484/ ipfs/specs#484 & #85

Implementation proposal

  • defaults remain the same, no filtering by default
  • keep it simple
    • new config options named same as ones from IPIP-484 (--filter-addrs and ---filter-protocols)
    • when set, apply them to the boxo/routing/http/client instance someguy uses.
@lidel lidel added the need/triage Needs initial labeling and prioritization label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

1 participant