Correctly handle with_cell_id in async do_execute (#1227)

ianthomas23 · web-flow · commit 8d60e674db5c · 2024-04-03T06:56:02.000-05:00
diff --git a/ipykernel/ipkernel.py b/ipykernel/ipkernel.py
@@ -382,7 +382,7 @@ async def run_cell(*args, **kwargs):
                 store_history=store_history,
                 silent=silent,
             )
-            if with_cell_id:
+            if with_cell_id and with_cell_id["cell_id"]:
                 kwargs.update(cell_id=cell_id)
 
             if should_run_async(

Original file line number	Diff line number	Diff line change
`@@ -382,7 +382,7 @@ async def run_cell(args, *kwargs):`
`382`	`382`	`store_history=store_history,`
`383`	`383`	`silent=silent,`
`384`	`384`	`)`
`385`		`- if with_cell_id:`
	`385`	`+ if with_cell_id and with_cell_id["cell_id"]:`
`386`	`386`	`kwargs.update(cell_id=cell_id)`
`387`	`387`
`388`	`388`	`if should_run_async(`