Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink arguments, etc., for AsROOTTree, etc. #71

Open
gordonwatts opened this issue Jun 29, 2021 · 0 comments
Open

Rethink arguments, etc., for AsROOTTree, etc. #71

gordonwatts opened this issue Jun 29, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@gordonwatts
Copy link
Member

gordonwatts commented Jun 29, 2021 •
edited
Loading

In the context of ServiceX the parameter for these guys don't make so much sense, even if they do make sense when running locally.

  • Currently the output data format is defined by the transformer, not by the user
  • In the ServiceX context, the output format is always columns, how they are written (root, etc.) is almost an afterthought.
  • Several ways to name columns

Rationalize!

  • And then document!
  • And then remove all the special fragile code from this repo and others (like func_adl_servicex, etc..
@gordonwatts gordonwatts added the enhancement New feature or request label Jun 29, 2021
@gordonwatts gordonwatts self-assigned this Jun 29, 2021
@gordonwatts gordonwatts removed their assignment Mar 22, 2022
@gordonwatts gordonwatts mentioned this issue Oct 29, 2022
Merged
gordonwatts added a commit to iris-hep/func_adl_servicex that referenced this issue Oct 29, 2022
@gordonwatts
Make sure AsParquetFiles works correctly with uproot (#53)
30e498c 
* Fixes #52 - AsParquetFiles now works properly with uproot
* Technical Debt:
   * Fixed up some tests to make them more robust
   * Black is now pulled for the dev version of this
   * `vscode` coverage task now work with latest version of `coverage`.

For the future:

* We need to change the symantics of the AsParquetFiles and AsROOTFiles - with a depreciation warning of some sort. No column names shoudl be in here - use a dict instead. This is a [future change](iris-hep/func_adl#71).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gordonwatts