Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powershell snippets run in reverse order and do not complete #708

Closed
ghost opened this issue Aug 8, 2022 · 20 comments
Closed

Powershell snippets run in reverse order and do not complete #708

ghost opened this issue Aug 8, 2022 · 20 comments
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented Aug 8, 2022

Bug description

Powershell .ps1 snippets run in reverse order and do not complete

Screenshots

Screenshot 2022-08-08 at 15 49 34

Screenshot 2022-08-08 at 15 49 58

Steps to reproduce

  1. Create any Powershell snippet
  2. Run in SSH session on Microsoft machine
  3. Error as in screenshot
@isontheline isontheline self-assigned this Aug 8, 2022
@isontheline isontheline added the 🐛 bug Something isn't working label Aug 8, 2022
@isontheline isontheline added this to the 19 - Octopus milestone Aug 8, 2022
@isontheline
Copy link
Owner

Hello @RichardBurt65 👋

Thank you a lot for your issue 👍

I will take a look at it in order to find and fix the trouble.

@isontheline
Copy link
Owner

isontheline commented Aug 15, 2022

@isontheline
Copy link
Owner

isontheline commented Aug 15, 2022

Hello @RichardBurt65

Have you some time to do a test?

Could you run this command :

Remove-PSReadlineKeyHandler Ctrl+Enter

=> Before running the snippet.

Does the snippet is pasted in good order?
If so I will be able to make a fix.

@ghost
Copy link
Author

ghost commented Aug 15, 2022 via email

@ghost
Copy link
Author

ghost commented Aug 16, 2022 via email

@isontheline
Copy link
Owner

Good Morning ☀️

Thank you a lot for your feedback!
Screenshots seems not to be attached when sending them through email.

Good news if commands are now in correct order : seems to be a "bug" inside PowerShell due to carriage return characters between macOS and Windows.

I will implement a hack inside WebSSH.

@ghost
Copy link
Author

ghost commented Aug 16, 2022 via email

@isontheline
Copy link
Owner

I think attachments could only be put from GitHub.

@ghost
Copy link
Author

ghost commented Aug 16, 2022

Screenshot 2022-08-16 at 07 54 10

@isontheline
Copy link
Owner

Does the snippet is executed when pressing ENTER after the last statement?

@ghost
Copy link
Author

ghost commented Aug 16, 2022 via email

@isontheline
Copy link
Owner

If you add an empty line to the end of tour snippet does it execute it?

Snippets should not execute statements if they are no carriage return at the end because some users don't want to launch them automatically.

@ghost
Copy link
Author

ghost commented Aug 16, 2022 via email

@isontheline
Copy link
Owner

Last question please : instead of executing the snippet => when you copy your statements and paste them to the terminal, does the paste works as expected?

@isontheline
Copy link
Owner

isontheline commented Aug 16, 2022

@RichardBurt65 Please also try out WebSSH 19.7 :
https://testflight.apple.com/join/QSrBK59z

You will also need to change the default carriage return to "\r\n" :
image

On your connection terminal setting.

@ghost
Copy link
Author

ghost commented Aug 17, 2022 via email

@isontheline
Copy link
Owner

I will release WebSSH 19.7 in a few days so you will be able to test it through the App Store

@ghost
Copy link
Author

ghost commented Aug 24, 2022 via email

@ghost
Copy link
Author

ghost commented Aug 26, 2022

After installing todays Ventura latest beta and WebSSH beta I can now confirm that the powershell issue has been tested and fixed.

Perfect and many thanks.

@isontheline
Copy link
Owner

Hello @RichardBurt65 👋

Great to hear that!
You're Welcome.

Many thanks for your feedback 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant