Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested doc improvements #83

Open
cfryanr opened this issue Mar 23, 2020 · 0 comments
Open

Suggested doc improvements #83

cfryanr opened this issue Mar 23, 2020 · 0 comments

Comments

@cfryanr
Copy link

cfryanr commented Mar 23, 2020

On Istio Slack:

From Shriram Rajagopalan (Tetrate):

Can you convert the readme into an Istio doc example or something?
This is quite useful. You can document it so that more people have access to it
Take this https://github.com/istio-ecosystem/authservice/tree/master/bookinfo-example#authz-with-review-service-optional and make this change part of official bookinfo so that you wont have to build your own.

As suggested above, we could PR the change to Istio's https://github.com/istio/istio/blob/master/samples/bookinfo/src/productpage/productpage.py#L185 file (fixing incoming_headers to allow the authorization header to be forwarded on backend app requests).

Second, migrate all your stuff to use new authN api
https://github.com/istio-ecosystem/authservice/blob/master/bookinfo-example/config/bookinfo-authn-policy-template-adding-reviews.yaml specificallty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant