Skip to content

Commit 26ab50c

Browse files
authored
Instruct helm to keep workload groups around on deletion (#3592)
* Instruct helm to keep workload groups around on deletion * Add release notes
1 parent 1d53815 commit 26ab50c

File tree

6 files changed

+12
-0
lines changed

6 files changed

+12
-0
lines changed

kubernetes/customresourcedefinitions.gen.yaml

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1/workload_group_alias.gen.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/workload_group.pb.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/workload_group.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ option go_package = "istio.io/api/networking/v1alpha3";
8282
// <!-- crd generation tags
8383
// +cue-gen:WorkloadGroup:groupName:networking.istio.io
8484
// +cue-gen:WorkloadGroup:versions:v1,v1beta1,v1alpha3
85+
// +cue-gen:WorkloadGroup:annotations:helm.sh/resource-policy=keep
8586
// +cue-gen:WorkloadGroup:labels:app=istio-pilot,chart=istio,heritage=Tiller,release=istio
8687
// +cue-gen:WorkloadGroup:subresource:status
8788
// +cue-gen:WorkloadGroup:scope:Namespaced

networking/v1beta1/workload_group_alias.gen.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

releasenotes/notes/3314.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
apiVersion: release-notes/v2
2+
kind: bug-fix
3+
area: installation
4+
releaseNotes:
5+
- |
6+
**Added** Added missing helm.sh/resource-policy=keep annotation to WorkloadGroup CRD

0 commit comments

Comments
 (0)