Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Drop usage of microFormat in player endpoint #4929

Open
8 tasks
unixfox opened this issue Sep 19, 2024 · 2 comments
Open
8 tasks

[Enhancement] Drop usage of microFormat in player endpoint #4929

unixfox opened this issue Sep 19, 2024 · 2 comments
Labels
enhancement Improvement of an existing feature

Comments

@unixfox
Copy link
Member

unixfox commented Sep 19, 2024

Since #4928, microformat is not available anymore from the player endpoint when using the client configured with po_token.

We should try to use something else, like from the next endpoint or from videoDetails.

What to migrate:

  • lengthSeconds: can be found in videoDetails, already a fallback
  • publishDate
  • premiere_timestamp
  • live_now
  • allowed_regions
  • family_friendly
  • description: fallback is already from next endpoint
  • genre
@unixfox unixfox added the enhancement Improvement of an existing feature label Sep 19, 2024
@unixfox unixfox changed the title [Enhancement] Drop usage of microFormat [Enhancement] Drop usage of microFormat in player endpoint Sep 19, 2024
@absidue
Copy link
Contributor

absidue commented Sep 20, 2024

I have opened #4934 to fix the live_now and premiere_timestamp fields.

@syeopite
Copy link
Member

syeopite commented Sep 22, 2024

Considering that the workaround is now broken I wonder if it'll make more sense to just revert the fix altogether rather than migrating everything away from microformat

Right! The fix still works on some IPs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants