Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xorBlock for ARM architecture #4

Open
kartben opened this issue Apr 6, 2016 · 4 comments
Open

Add xorBlock for ARM architecture #4

kartben opened this issue Apr 6, 2016 · 4 comments

Comments

@kartben
Copy link

kartben commented Apr 6, 2016

Trying to cross compile for ARM, i got bitten by a missing implementation of the xorBlock function for ARM...

@kartben
Copy link
Author

kartben commented Apr 6, 2016

Actually, I think I don't really understand the need for an arch specific implementation of xorBlock? Is this for performance optimization? For disallowing xor's on blocks that are not aligned?
Isn't the "standard" xor implementation enough? https://golang.org/src/crypto/cipher/xor.go
Thanks!

/cc @jvermillard

@jacobsa
Copy link
Owner

jacobsa commented Apr 7, 2016

There are arch-specific implementations because each contains arch-specific assumptions about the size of a block in relation to the size of uintptr.

crypto. fastXORWords is functionally equivalent but the support for variable-length slices may make it slower. I would want to see good benchmark results before switching to something similar. I specifically switched away from this strategy in 61fbfe1, but didn't record the results that caused me to do so.

Feel free to send a pull request for arm.

@ivajloip
Copy link
Contributor

ivajloip commented Apr 8, 2016

Pull request #5 tries to fix this issue.

@paralin
Copy link

paralin commented Jun 25, 2022

As far as I can tell this all works perfectly on ARM today, maybe this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants