Codecov Report

Attention: Patch coverage is 10.81081% with 33 lines in your changes missing coverage. Please review.

Project coverage is 95.83%. Comparing base (384203d) to head (4c624a3).

@@            Coverage Diff             @@
##             main    #6654      +/-   ##
==========================================
- Coverage   96.00%   95.83%   -0.17%     
==========================================
  Files         363      364       +1     
  Lines       20603    20639      +36     
==========================================
  Hits        19780    19780              
- Misses        628      663      +35     
- Partials      195      196       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Please see comments in #6608, the same applies here

@yurishkuro the /deep-dependencies url is working now, but there are some issues.

• Actually jaeger-ui tries to find a focalNode (ie focalService and focalOperation), which is chosen from all the operations of the chosen service. Hence there doesnt seem to be a simple way of just hardcoding the deep-dependencies.
  To show the working in the ui, I chose the hotrod example and a specific service (namely driver) to show the rendering.
• I tried to set a default value for the focalNode as a temporary solution, but the problem remains that the focalService and focalOperation will have to exist for this to work.

• As per your suggestion, I changed the backend to /api/deep-dependencies. However, the frontend still looks for the backend data on /analytics/v1/dependencies . So we will need to raise a PR in the ui repo for the same.

Sorry I don't follow your points about focal service. Isn't that a user choice after you return the data? Is that an input to the endpoint that returns the data? In either case the dummy endpoint can ignore that input and always return the same data, and to test it you can specify the focal service in the query URL (I assume).

Another thing I didn't understand is why did you have to run hotrod in your screencast? If the endpoint always returns dummy data, what was the point of sending data to Jaeger from HotROD?

And yes, you will need to make a change to the UI to use a different URL for the data. We could make it configurable in the UI, to keep it backwards compatible.

In either case the dummy endpoint can ignore that input and always return the same data, and to test it you can specify the focal service in the query URL (I assume).

@yurishkuro
I was actually trying to find workarounds of not hardcoding the service and operation, and directly going to /deep-dependencies and chosing a service and operation, which was causing a problem. But I understand the need now.

If we go to http://localhost:16686/deep-dependencies?density=ppe&operation=opA&service=serviceA we get the required graph.

This was also the reason I was running the hotrod example, to mock services and operations.

Are there any other considerations? Otherwise, I will move on and write the tests for the same, and also raise a pr in the ui.