Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall Project Review #21

Open
sunny2319 opened this issue Nov 9, 2022 · 0 comments
Open

Overall Project Review #21

sunny2319 opened this issue Nov 9, 2022 · 0 comments

Comments

@sunny2319
Copy link
Collaborator

  1. Readme file is maintained properly just add the workflow
  2. Naming convention is not followed at some places
  3. validations are missing at all place
  4. Extra variables are used at multiple places
  5. password is a very sensitive thing which should be stored in encrypted form and during verification compare encrypted form only ( convert login userpass also in encrypted form and then compare)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant