From 58352ce07f82a615ce373c67eb459ea5df4a081d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leonard=20Br=C3=BCnings?= Date: Fri, 1 Sep 2017 19:29:39 +0200 Subject: [PATCH] Fix jersey-netty-connector to allow unauthenticated proxies --- .../glassfish/jersey/netty/connector/NettyConnector.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/connectors/netty-connector/src/main/java/org/glassfish/jersey/netty/connector/NettyConnector.java b/connectors/netty-connector/src/main/java/org/glassfish/jersey/netty/connector/NettyConnector.java index 42394a248c..a7349e291d 100644 --- a/connectors/netty-connector/src/main/java/org/glassfish/jersey/netty/connector/NettyConnector.java +++ b/connectors/netty-connector/src/main/java/org/glassfish/jersey/netty/connector/NettyConnector.java @@ -193,9 +193,12 @@ protected void initChannel(SocketChannel ch) throws Exception { final String password = ClientProperties.getValue( config.getProperties(), ClientProperties.PROXY_PASSWORD, String.class); - p.addLast(new HttpProxyHandler(new InetSocketAddress(u.getHost(), - u.getPort() == -1 ? 8080 : u.getPort()), - userName, password)); + InetSocketAddress proxyAddress = new InetSocketAddress(u.getHost(), u.getPort() == -1 ? 8080 : u.getPort()); + + HttpProxyHandler httpProxyHandler = ((userName == null) || (password == null)) ? + new HttpProxyHandler(proxyAddress) : + new HttpProxyHandler(proxyAddress, userName, password); + p.addLast(httpProxyHandler); } p.addLast(new HttpClientCodec());