Skip to content

Commit 11cf37a

Browse files
committed
refactor(dbm-services): 资源池代码优化 TencentBlueKing#15361
1 parent 5e3be93 commit 11cf37a

2 files changed

Lines changed: 14 additions & 28 deletions

File tree

dbm-services/common/db-resource/internal/controller/manage/rs_resource_param.go

Lines changed: 7 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -163,26 +163,16 @@ func (h *MachineResourceParamHandler) QueryResourceParam(c *gin.Context) {
163163
// Limit request body size
164164
c.Request.Body = http.MaxBytesReader(c.Writer, c.Request.Body, 1<<20) // 1MB
165165

166-
// Parse and validate request parameters
166+
// Parse and validate request parameters using Prepare
167167
var req QueryResourceParamReq
168-
if err := c.ShouldBind(&req); err != nil {
169-
logger.Error("ShouldBind Failed: %s", err.Error())
170-
c.JSON(http.StatusBadRequest, controller.Response{
171-
Code: http.StatusBadRequest,
172-
Message: "Invalid request parameters",
173-
RequestId: c.GetString("request_id"),
174-
})
168+
if err := h.Prepare(c, &req); err != nil {
175169
return
176170
}
177171

178172
// Custom validation
179173
if err := req.Validate(); err != nil {
180174
logger.Error("Validate Failed: %s", err.Error())
181-
c.JSON(http.StatusBadRequest, controller.Response{
182-
Code: http.StatusBadRequest,
183-
Message: err.Error(),
184-
RequestId: c.GetString("request_id"),
185-
})
175+
h.SendResponse(c, err, nil)
186176
return
187177
}
188178

@@ -195,11 +185,7 @@ func (h *MachineResourceParamHandler) QueryResourceParam(c *gin.Context) {
195185
requestBodies, err := model.QueryResourceParamByBillOrTask(ctx, req.BillID, req.TaskID, req.Limit, req.Offset)
196186
if err != nil {
197187
logger.Error("QueryResourceParamByBillOrTask failed: %v, request_id=%s", err, c.GetString("request_id"))
198-
c.JSON(http.StatusInternalServerError, controller.Response{
199-
Code: http.StatusInternalServerError,
200-
Message: "Failed to query resource parameters",
201-
RequestId: c.GetString("request_id"),
202-
})
188+
h.SendResponse(c, err, nil)
203189
return
204190
}
205191

@@ -215,14 +201,9 @@ func (h *MachineResourceParamHandler) QueryResourceParam(c *gin.Context) {
215201
logger.Info("QueryResourceParam success: found %d records, request_id=%s", len(formattedList),
216202
c.GetString("request_id"))
217203

218-
// Return response
219-
c.JSON(http.StatusOK, controller.Response{
220-
Code: http.StatusOK,
221-
Message: "success",
222-
Data: QueryResourceParamResp{
223-
RequestBodyList: formattedList,
224-
},
225-
RequestId: c.GetString("request_id"),
204+
// Return response using SendResponse
205+
h.SendResponse(c, nil, QueryResourceParamResp{
206+
RequestBodyList: formattedList,
226207
})
227208
}
228209

dbm-services/common/db-resource/internal/svr/apply/apply_base.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,12 @@ func (a *ObjectDetail) GetDiskMatchInfo() (message string) {
382382
func (a *ObjectDetail) GetMessage() (message string) {
383383
message += fmt.Sprintf(" group: %s\n", a.GroupMark)
384384
if len(a.DeviceClass) > 0 {
385-
message += fmt.Sprintf("device_class: %v\n", a.DeviceClass)
385+
message += fmt.Sprintf("CC机型: %v\n", a.DeviceClass)
386+
}
387+
if len(a.Labels) > 0 {
388+
message += fmt.Sprintf("标签: %v\n", a.Labels)
389+
} else {
390+
message += "标签: 无\n"
386391
}
387392
if a.Spec.NotEmpty() {
388393
if a.Spec.Cpu.IsNotEmpty() {
@@ -394,7 +399,7 @@ func (a *ObjectDetail) GetMessage() (message string) {
394399
}
395400
message += a.GetDiskMatchInfo()
396401
if !a.LocationSpec.IsEmpty() {
397-
message += fmt.Sprintf("city: %s \n", a.LocationSpec.City)
402+
message += fmt.Sprintf("城市: %s \n", a.LocationSpec.City)
398403
if len(a.LocationSpec.SubZoneIds) > 0 {
399404
if a.LocationSpec.IsExclude() {
400405
message += fmt.Sprintf("subzoneId 必须不能存在这些园区中: %v", translateSubzoneIdToName(a.LocationSpec.SubZoneIds))

0 commit comments

Comments
 (0)