Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model delete #178

Closed
mr-linch opened this issue Jun 23, 2015 · 3 comments
Closed

Model delete #178

mr-linch opened this issue Jun 23, 2015 · 3 comments

Comments

@mr-linch
Copy link

How I can save history records when models delete?

@macro1
Copy link
Collaborator

macro1 commented Jun 28, 2015

This should already be the case... We have a test that ensures historical records are created when the model is deleted. Maybe there is something else going on? Are you bulk deleting? All history generation is triggered off of changes to model instances, not querysets.

@matheusjardimb
Copy link

possibly, @mr-linch is just facing the same scenario as I:

  • Create record
  • Edit record
  • See history through django admin
  • Delete record
  • 404 in django admin record

Am I right? Do you want to see the deleted record as part of the record history? (like this #72 )

@macro1
Copy link
Collaborator

macro1 commented Dec 2, 2015

As both #72 is resolved and deletes for instances are already supported I'm closing this. If the untracked deletes are being performed on querysets, it's a known issue with the way we use signals to track changes, see #174.

@macro1 macro1 closed this as completed Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants