You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As @Quuxplusone points out on this PR there should be further testing added for testing to ensure types correctly make use of allocator_traits<A>::pointer.
Adding Boost as a dependency is a little heavy weight as we require a mechanism for supporting the dependency (perhaps Conan?). However, we could emulate this with a custom offset_ptr implementation for the tests.
The text was updated successfully, but these errors were encountered:
auto* mem = cb_alloc_traits::allocate(cb_alloc, 1);
allocate and deallocate need to work with the allocator's pointer type, but construct and destroy work with raw pointers. You need to use std::to_address and std::pointer_traits<P>::pointer_to to convert between them.
As @Quuxplusone points out on this PR there should be further testing added for testing to ensure types correctly make use of
allocator_traits<A>::pointer
.Adding Boost as a dependency is a little heavy weight as we require a mechanism for supporting the dependency (perhaps Conan?). However, we could emulate this with a custom
offset_ptr
implementation for the tests.The text was updated successfully, but these errors were encountered: