diff --git a/lib/main.sh b/lib/main.sh index c6d7766..8e1cd31 100644 --- a/lib/main.sh +++ b/lib/main.sh @@ -58,8 +58,8 @@ function run() { [[ "${ERRORLEVEL}" == "1" ]] && echo "${OUTPUT}" | exit_if_found_in_json "warning" [[ "${ERRORLEVEL}" == "1" ]] && echo "${OUTPUT}" | exit_if_found_in_json "error" - # Any output would imply an error - [[ "${ERRORLEVEL}" == "2" && "${OUTPUT}" != "" ]] && exit 1 + # An empty json array would imply an error + [[ "${ERRORLEVEL}" == "2" && "${OUTPUT}" != "[]" ]] && exit 1 # You either did well or chose to become a better person exit 0 diff --git a/test/e2e.sh b/test/e2e.sh index e2ae31c..adaad7a 100755 --- a/test/e2e.sh +++ b/test/e2e.sh @@ -35,6 +35,7 @@ test_override_errorlevel() { assert "error_level=-1 dockerfile=fixtures/Dockerfile-error ${HL}" assert_fail "dockerfile=fixtures/Dockerfile-error ${HL}" assert_fail "error_level=2 dockerfile=fixtures/Dockerfile-error ${HL}" + assert "error_level=2 dockerfile=fixtures/Dockerfile-valid ${HL}" assert "dockerfile=fixtures/Dockerfile-warning ${HL}" assert_fail "error_level=1 dockerfile=fixtures/Dockerfile-warning ${HL}" } diff --git a/test/fixtures/Dockerfile-valid b/test/fixtures/Dockerfile-valid new file mode 100644 index 0000000..4087e94 --- /dev/null +++ b/test/fixtures/Dockerfile-valid @@ -0,0 +1,3 @@ +FROM alpine:3.12 + +RUN ls \ No newline at end of file