From a1b025744e8439dfafbdee76d748e485c730f357 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johan=20Bergstro=CC=88m?= Date: Mon, 19 Apr 2021 20:01:30 -0400 Subject: [PATCH] fix: pin shellcheck version --- .github/workflows/lint.yml | 8 ++++---- .github/workflows/test.yml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 9d94950..448b532 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -5,14 +5,14 @@ jobs: shellcheck: runs-on: ubuntu-20.04 name: shellcheck + env: + SHELLCHECK_VERSION: 0.7.2 steps: - uses: actions/checkout@v2 - name: install shellcheck - env: - scversion: stable run: | - wget -qO- "https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz" | tar -xJ - sudo cp "shellcheck-${scversion}/shellcheck" /usr/local/bin/ + wget -qO- "https://github.com/koalaman/shellcheck/releases/download/v${{ env.SHELLCHECK_VERSION }}/shellcheck-v${{ env.SHELLCHECK_VERSION }}.linux.x86_64.tar.xz" | tar -xJ + sudo cp "shellcheck-v${{ env.SHELLCHECK_VERSION }}/shellcheck" /usr/local/bin/ - name: verify shell scripts run: shellcheck hadolint.sh lib/*.sh test/*.sh prettier: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7c1d4eb..399e973 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,20 +1,20 @@ name: test on: pull_request -env: - HADOLINT_VERSION: $(cat HADOLINT_VERSION) - BASH_UNIT_VERSION: 1.7.1 - jobs: bash_unit: name: bash_unit runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v2 + - name: fetch hadolint version + run: echo "HADOLINT_VERSION=$(cat HADOLINT_VERSION)" >> ${GITHUB_ENV} - name: install hadolint run: | curl -LO https://github.com/hadolint/hadolint/releases/download/v${{ env.HADOLINT_VERSION }}/hadolint-Linux-x86_64 && sudo mv hadolint-Linux-x86_64 /usr/local/bin/hadolint && sudo chmod +x /usr/local/bin/hadolint - name: install bash_unit + env: + BASH_UNIT_VERSION: 1.7.1 run: | curl -L https://github.com/pgrange/bash_unit/archive/refs/tags/v${{ env.BASH_UNIT_VERSION }}.tar.gz | tar xz --strip=1 -C /tmp/ && sudo mv /tmp/bash_unit /usr/local/bin - name: output versions