Skip to content

Conversation

@Chef5
Copy link
Contributor

@Chef5 Chef5 commented Aug 25, 2025

这个 PR 做了什么? (简要描述所做更改)
修复抖音小程序中签名组件报错,因为代码中只判断了微信小程序和京东小程序

这个 PR 是什么类型? (至少选择一个)

这个 PR 是否已自测:

  • [✅ ] 已自测,本地项目修改node_modules

Copy link
Collaborator

@Miles-hxy Miles-hxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那是不是直接判断不是web就行了

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v4@700c7a2). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             v4    #3289   +/-   ##
=====================================
  Coverage      ?   81.48%           
=====================================
  Files         ?      226           
  Lines         ?    18163           
  Branches      ?     2496           
=====================================
  Hits          ?    14800           
  Misses        ?     3345           
  Partials      ?       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Chef5
Copy link
Contributor Author

Chef5 commented Aug 26, 2025

那是不是直接判断不是web就行了

Taro.getEnv()还有ReactNative、QUICKAPP 快应用,这两类应该不属于小程序吧

@Miles-hxy Miles-hxy merged commit fe5c012 into jd-opensource:v4 Sep 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants