diff --git a/desktop/js/administration.js b/desktop/js/administration.js index 22a075b700..a0e6edad68 100644 --- a/desktop/js/administration.js +++ b/desktop/js/administration.js @@ -523,7 +523,9 @@ document.getElementById('in_searchConfig').addEventListener('keyup', function(ev if (tabId == undefined) return //Create new tablink ? if (!tabsArr.includes(tabId)) { - tabName = document.querySelector('a[data-target="#' + tabId + '"]').innerHTML + const _tabEl = document.querySelector('a[data-target="#' + tabId + '"]') + if (!_tabEl) return + tabName = _tabEl.innerHTML if (tabName != null) { var newTabLink = document.createElement('div') newTabLink.innerHTML = '' + tabName + '' diff --git a/desktop/js/backup.js b/desktop/js/backup.js index 1ec4ad5b4b..0718f18469 100644 --- a/desktop/js/backup.js +++ b/desktop/js/backup.js @@ -170,9 +170,11 @@ if (!jeeFrontEnd.backup) { options += '' } } else { - document.querySelector('.bt_restoreRepoBackup[data-repo="' + _repo + '"]').addClass('disabled') + const _btEl = document.querySelector('.bt_restoreRepoBackup[data-repo="' + _repo + '"]') + if (_btEl) _btEl.addClass('disabled') } - document.querySelector('.sel_restoreCloudBackup[data-repo="' + _repo + '"]').innerHTML = options + const _selEl = document.querySelector('.sel_restoreCloudBackup[data-repo="' + _repo + '"]') + if (_selEl) _selEl.innerHTML = options } }) }, diff --git a/desktop/js/object.js b/desktop/js/object.js index d78a675586..8d02c59023 100644 --- a/desktop/js/object.js +++ b/desktop/js/object.js @@ -847,7 +847,7 @@ document.getElementById('div_conf').addEventListener('click', function(event) { success: function() { jeeFrontEnd.modifyWithoutSave = false document.getElementById('bt_gotoDashboard').querySelectorAll(':scope li a').forEach(_link => { - if (_link.href.includes(removeId)) _link.parentNode.remove() + if (_link.href.includes(id)) _link.parentNode.remove() }) jeedomUtils.loadPage('index.php?v=d&p=object&removeSuccessFull=1') } diff --git a/desktop/js/overview.js b/desktop/js/overview.js index b9e6887272..29b6703af1 100644 --- a/desktop/js/overview.js +++ b/desktop/js/overview.js @@ -55,7 +55,9 @@ if (!jeeFrontEnd.overview) { }, updateSummary: function(_className) { _className = _className.replace('objectSummaryContainer ', '') - var parent = document.querySelector('.' + _className).closest('.objectPreview') + const _classEl = document.querySelector('.' + _className) + if (!_classEl) return + var parent = _classEl.closest('.objectPreview') if (parent == null) return parent.querySelector('.topPreview')?.querySelectorAll('.objectSummaryParent')?.remove() var pResume = parent.querySelector('.resume') diff --git a/desktop/js/replace.js b/desktop/js/replace.js index a4e017243b..cc362f66ea 100644 --- a/desktop/js/replace.js +++ b/desktop/js/replace.js @@ -129,7 +129,8 @@ if (!jeeFrontEnd.replace) { return select }, resetEqlogicSelect: function(eqlogicId=-1) { - document.querySelector('#eqSource ul.eqLogic[data-id="' + eqlogicId + '"] select.selectEqReplace').jeeValue('') + const _selEl = document.querySelector('#eqSource ul.eqLogic[data-id="' + eqlogicId + '"] select.selectEqReplace') + if (_selEl) _selEl.jeeValue('') }, resetCmdSelects: function(eqlogicId=-1) { document.querySelectorAll('#eqSource ul.eqLogic[data-id="' + eqlogicId + '"] li.cmd').forEach( _cmd => { diff --git a/desktop/js/scenario.js b/desktop/js/scenario.js index 2dd3778ada..e3bac6a0f9 100644 --- a/desktop/js/scenario.js +++ b/desktop/js/scenario.js @@ -2062,6 +2062,7 @@ document.getElementById('generaltab').addEventListener('click', function(event) document.getElementById('scenarioThumbnailDisplay').unseen() jeeP.printScenario(_target.getAttribute('data-scenario_id')) } + return } if (_target = event.target.closest('.action_link')) { @@ -2215,10 +2216,12 @@ document.getElementById('scenariotab').addEventListener('click', function(event) if (_target = event.target.closest('#bt_cancelElementSave')) { jeeDialog.modal(document.getElementById('md_addElement'))._jeeDialog.hide() + return } if (_target = event.target.closest('#bt_crossElementSave')) { jeeDialog.modal(document.getElementById('md_addElement'))._jeeDialog.hide() + return } if (_target = event.target.closest('input:not([type="checkbox"]).expressionAttr, textarea.expressionAttr')) { //ctrl-click input popup diff --git a/desktop/js/types.js b/desktop/js/types.js index 8a8ae6a24b..59bddcda10 100644 --- a/desktop/js/types.js +++ b/desktop/js/types.js @@ -253,12 +253,16 @@ if (!jeeFrontEnd.types) { var eqName, cmdName, thisCmd, thisClass, select for (var _id in queryEqIds) { inner += '