Skip to content

github_edit_link contains pagination path #213

Closed

Description

@cmbuckley

If a page is paginated: true, all pages (except the first) contain the paginate_path in the github_edit_link.

I created a minimal demo here, but if you have the following config:

repository: "owner/repo"
paginate_path: "page/:num/"

and an index.html with paginated: true, then when you visit /page/2/ the github_edit_link will contain /page/2/index.html instead of just /index.html.

The issue here would seem to come from jekyll-paginate, because the page.path is set to /page/2/index.html. It seemed better to raise the issue here since that repo is not maintained.

Activity

  1. jekyllbot commented on Oct 24, 2021

    @jekyllbot
    Contributor

    This issue has been automatically marked as stale because it has not been commented on for at least two months.

    The resources of the Jekyll team are limited, and so we are asking for your help.

    If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

    If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

    This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

  2. added 2 commits that reference this issue on Dec 22, 2021
    e22a8ac
    982091a
  3. jekyllbot commented on Feb 22, 2022

    @jekyllbot
    Contributor

    This issue has been automatically marked as stale because it has not been commented on for at least two months.

    The resources of the Jekyll team are limited, and so we are asking for your help.

    If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

    If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

    This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

  4. locked and limited conversation to collaborators on Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions