Fixed Reset button for Selector view #1247
Conversation
There was a problem hiding this comment.
Sadly, this isn't the correct solution. That StateObject is there as an intermediate "binding" to update the view if it couldn't be from a parent view. For example with this change, the font selection breaks. See BindingBox for its justification.
Swiftfin/Shared/Objects/BindingBox.swift
Line 15 in 4cba762
The difference in behavior comes in FilterView and how we perform some indirection wackiness to update the correct filters. Filters are a bit confusing.
Swiftfin/Swiftfin/Views/FilterView.swift
Line 44 in 4cba762
I would be able to take a look at this a bit more later but I may just revert the BindingBox's usage from #1216. I only implemented it since I thought I could save some code, but will revert if it's causing more issues than solving them.
|
If we want to support both use cases, maybe BindingBox can enable or disable its 2 way binding. From what i can see, BindingBox is a binding but only 1 way right? The other way can be a boolean that is passed in with a default of 2 way, and in special cases use 1 way instead. |
|
Bindings should ideally/really always be both ways. |
Closes #1246
Fixes the "Reset" button in the filter selector not resetting the selector itself, only the data outside the selector.