From f5b83f1fee6e8e5d2b8b2299ed9928fdcb06f8a6 Mon Sep 17 00:00:00 2001
From: Dmitry Platonov <47667812+Pldi23@users.noreply.github.com>
Date: Mon, 10 Jun 2024 11:35:27 +0300
Subject: [PATCH] [JENKINS-73276] do not allow user without admin permission to
 save empty form (#1572)

---
 .../plugins/kubernetes/KubernetesFolderProperty.java     | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesFolderProperty.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesFolderProperty.java
index 4f7f2c5fd1..39f6106f64 100644
--- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesFolderProperty.java
+++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesFolderProperty.java
@@ -74,15 +74,16 @@ public static boolean isAllowed(KubernetesSlave agent, Job job) {
 
     @Override
     public AbstractFolderProperty<?> reconfigure(StaplerRequest req, JSONObject form) throws FormException {
-        if (form == null) {
-            return null;
-        }
-
         // ignore modifications silently and return the unmodified object if the user
         // does not have the ADMINISTER Permission
         if (!userHasAdministerPermission()) {
             return this;
         }
+
+        if (form == null) {
+            return null;
+        }
+
         // Backwards compatibility: this method was expecting a set of entries PREFIX_USAGE_PERMISSION+cloudName -->
         // true | false
         // Now we're getting a set of permitted cloud names inside permittedClouds entry