Bazel build on windows and linux #292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jeremy-rifkin
left a comment
jeremy-rifkin
left a comment
There was a problem hiding this comment.
Thanks so much for taking the time to do this! There's one setting that I'm wondering about but otherwise lgtm!
| "//conditions:default": COMMON_FLAGS, | ||
| }, | ||
| ), | ||
| defines = ["CPPTRACE_STATIC_DEFINE"], |
Owner
There was a problem hiding this comment.
This is an option that needs to be specified by anyone using the static cpptrace build, it shouldn't be set by cpptrace itself for cpptrace's sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.