fix: prevent infinite loop when pressing Escape on policy generation error

When the policy generation API returned an error, pressing Escape on the
review step would loop back to the loading step and re-trigger the API
call, creating an infinite loop. The root cause was the double goBack()
pattern (one immediate, one via setTimeout) suffering from stale closures
— both calls saw the same step, so the second never reached the
description step, while the first landed on loading and re-fired the
useEffect.

The fix uses a skipGeneration ref: when navigating back from review, the
ref is set to true and a single goBack() moves to the loading step. The
useEffect detects the ref, resets it, and calls goBack() again (now with
the correct step in scope) to reach the description step — without ever
starting generation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: jesseturner21

src/cli/tui/screens/policy/AddPolicyScreen.tsx

@@ -11,7 +11,7 @@ import { POLICY_SOURCE_METHOD_OPTIONS, POLICY_STEP_LABELS, VALIDATION_MODE_OPTIO
 import { useAddPolicyWizard } from './useAddPolicyWizard';
 import { Box, Text } from 'ink';
 import Spinner from 'ink-spinner';
-import React, { useCallback, useEffect, useMemo, useState } from 'react';
+import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react';
 
 interface AddPolicyScreenProps {
   onComplete: (config: AddPolicyConfig) => void;
@@ -37,6 +37,7 @@ export function AddPolicyScreen({
   // Generation state
   const [generatedPolicy, setGeneratedPolicy] = useState<string | null>(null);
   const [generationError, setGenerationError] = useState<string | null>(null);
+  const skipGeneration = useRef(false);
 
   const engineItems: SelectableItem[] = useMemo(
     () =>
@@ -147,9 +148,8 @@ export function AddPolicyScreen({
       } else {
         setGeneratedPolicy(null);
         setGenerationError(null);
+        skipGeneration.current = true;
         wizard.goBack();
-        // Go back twice — past loading to description
-        setTimeout(() => wizard.goBack(), 0);
       }
     },
     [generatedPolicy, wizard]
@@ -161,15 +161,23 @@ export function AddPolicyScreen({
     onExit: () => {
       setGeneratedPolicy(null);
       setGenerationError(null);
+      skipGeneration.current = true;
       wizard.goBack();
-      setTimeout(() => wizard.goBack(), 0);
     },
     isActive: isGenerateReviewStep,
   });
 
   // Real policy generation when entering the loading step
   useEffect(() => {
     if (!isGenerateLoadingStep) return undefined;
+    if (skipGeneration.current) {
+      skipGeneration.current = false;
+      // Navigate back past the loading step to the description step.
+      // This runs after React re-rendered with the loading step active,
+      // so goBack() correctly sees 'source-generate-loading' as current step.
+      wizard.goBack();
+      return undefined;
+    }
 
     let cancelled = false;
 
@@ -318,7 +326,7 @@ export function AddPolicyScreen({
           <TextInput
             key="generate-description"
             prompt="Describe your policy in natural language"
-            initialValue=""
+            initialValue={wizard.config.naturalLanguageDescription}
             expandable
             onSubmit={wizard.setNaturalLanguageDescription}
             onCancel={goBackOrExit}