Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceHandler & ResourceServlet (all envs) do not agree on UseFileMapping default #12700

Open
joakime opened this issue Jan 10, 2025 · 1 comment
Open

ResourceHandler & ResourceServlet (all envs) do not agree on UseFileMapping default #12700

joakime opened this issue Jan 10, 2025 · 1 comment
Labels
Bug For general bugs on Jetty side

Comments

@joakime
Copy link
Contributor

joakime commented Jan 10, 2025

Jetty version(s)
12.1.x

Jetty Environment
all

Java version/vendor (use: java -version)
Any

OS type/version
Any

Description
The ResourceHandler has it's useFileMapping field set to true by default.
The ResourceServlet in all envs has useFileMapping set to false by default.

Make all places agree, prefer false as default.
@joakime joakime added the Bug For general bugs on Jetty side label Jan 10, 2025
@janbartel
Copy link
Contributor

@joakime as an aside, the DefaultServlet which <is-a> ResourceServlet sets it to true in all ee webdefault.xml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
Jetty 12.1.0
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joakime @janbartel