Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build checking #57

Open
jmcc0nn3ll opened this issue Jul 8, 2024 · 7 comments
Open

Build checking #57

jmcc0nn3ll opened this issue Jul 8, 2024 · 7 comments
Assignees

Comments

@jmcc0nn3ll
Copy link
Contributor

We ran across the following error trying to deploy the website for the latest releases. If you look at the source file it is clearly an issue with a commit last week from @janbartel which was not caught by anything from Jenkins, or if it was it was not well reported to get fixed?

@olamy I thought you had setup a build to catch these things?

15:43:24 [INFO] [INFO] ------------------------------------------------------------------------
15:43:24 [INFO] [INFO] BUILD SUCCESS
15:43:24 [INFO] [INFO] ------------------------------------------------------------------------
15:43:24 [INFO] [INFO] Total time: 05:21 min
15:43:24 [INFO] [INFO] Finished at: 2024-07-08T15:43:24Z
15:43:24 [INFO] [INFO] ------------------------------------------------------------------------
15:43:30 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME
15:43:31 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --args="--add-modules=http" --highlight="([a-z-]+ transitively enabled)"
15:43:32 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --args="--module=http" --highlight="({.
:8080})"
15:43:35 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --args="--module=http jetty.http.port=9999" --highlight="({.:9999})"
15:43:38 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --args="--module=http jetty.http.port=8080" --highlight="({.
:8080})"
15:43:41 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --setup-args="--add-modules=http" --args="--add-modules=ee10-deploy"
15:43:43 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --setup-args="--add-modules=http,deploy,ee10-demo-simple" --highlight="WebAppContext"
15:43:47 [INFO] [15:43:47.549] WARN (asciidoctor): id assigned to section already in use: jetty
15:43:47 [INFO] file: documentation/jetty/modules/operations-guide/pages/deploy/index.adoc:203
15:43:47 [INFO] source: https://github.com/jetty/jetty.project (branch: jetty-12.0.x | start path: documentation/jetty)

@jmcc0nn3ll
Copy link
Contributor Author

jmcc0nn3ll commented Jul 8, 2024

https://jenkins.webtide.net/blue/organizations/jenkins/website%2Fjetty.website/activity/

This build should run whenever there is a commit under documentation/jetty and should report failures, @joakime fired this build manually.

@joakime
Copy link
Contributor

joakime commented Jul 8, 2024

See this build (kicked off manually) to see the error.

https://jenkins.webtide.net/blue/organizations/jenkins/website%2Fjetty.website/detail/main/29/pipeline

@olamy I made the following change to (hopefully) address the issue ...

jetty/jetty.project@803fe5c

@olamy
Copy link
Member

olamy commented Jul 8, 2024

arghh true I forgot to add some triggers based on jetty10/11/12 branches push.

@janbartel
Copy link

There's something wrong with the local maven build then too because I built the doco according to the README several times and didn't see an error.

@olamy
Copy link
Member

olamy commented Jul 8, 2024

There's something wrong with the local maven build then too because I built the doco according to the README several times and didn't see an error.

Did you build after Joakim fix?
Per default, the build here use jetty-12.0.x branch so if you want to test your PR this need some manual changes here

branches: jetty-{12,11,10}.0.x

@janbartel
Copy link

@olamy dunno, didn't know there was something manual required, I just used the readme and my branch.

@olamy
Copy link
Member

olamy commented Jul 9, 2024

no worries. nothing was really defined there. I will add some auto triggering, and we will get informed, and people will get really blamed with automatic bank transfer to the "build failure jar"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants