cleanup

Author: jheiling

Scripts/SignalListener.cs

@@ -1,4 +1,5 @@
-using UnityEngine;
+using System.Diagnostics.CodeAnalysis;
+using UnityEngine;
 using UnityEngine.Events;
 
 namespace Signals
@@ -44,14 +45,17 @@ public bool InvokeImmediately
 
         void AddListenerToSignal()
         {
-            if (_signal)
+            if (_signal != null)
             {
                 _signal.AddListener(_onUpdated.Invoke);
                 if (_invokeImmediately) _onUpdated.Invoke();
             }
         }
 
-        void RemoveListenerFromSignal() => _signal?.RemoveListener(_onUpdated.Invoke);
+        void RemoveListenerFromSignal()
+        {
+            if(_signal != null) _signal.RemoveListener(_onUpdated.Invoke);
+        }
     }
 
 
@@ -108,6 +112,10 @@ void AddListenerToSignal()
             }
         }
 
-        void RemoveListenerFromSignal() => _signal?.RemoveListener(_onUpdated.Invoke);
+        [SuppressMessage("Style", "IDE0031:Use null propagation", Justification = "_signal is a Unity Object")]
+        void RemoveListenerFromSignal()
+        {
+            if (_signal != null) _signal.RemoveListener(_onUpdated.Invoke);
+        }
     }
 }

Scripts/ValueReference.cs

@@ -47,18 +47,7 @@ public T LocalValue
         /// <summary>The <see cref="Signal.Value"/> of the <see cref="Signal"/> if <see cref="UseLocalValue"/> is false, the <see cref="LocalValue"/> otherwise.</summary>
         public T Value
         {
-            get
-            {
-                if (_useLocalValue)
-                {
-                    return _localValue;
-                }
-                else
-                {
-                    if (_signal == null) throw new NullReferenceException();
-                    return _signal.Value;
-                }
-            }
+            get => _useLocalValue ? _localValue : _signal == null ? throw new NullReferenceException() : _signal.Value;
             set
             {
                 if (_useLocalValue)