fix: store generated salt in already instantiated UserClient before returning

Author: Laizerox

src/Wowemu/SRP/UserClient.php

@@ -115,7 +115,7 @@ private function computeVerifier(BigInteger $x): BigInteger
      */
     public function generateSalt(): string
     {
-        return $this->getRandomNumber(32);
+        return $this->salt = $this->getRandomNumber(32);
     }
 
     /**

tests/UserClientTest.php

@@ -36,11 +36,37 @@ public function dataProvider(): array
     /**
      * @param $username
      * @param $password
-     * @param $salt
+     * @param $expectedSalt
      * @param $expectedVerifier
      *
+     * @throws Exception
      * @dataProvider dataProvider
+     */
+    public function testNewAccountGeneration($username, $password, $expectedSalt, $expectedVerifier): void
+    {
+        // Create a client mock for this test case (equivalent of new UserClient($username)
+        $client = $this->getMockBuilder(UserClient::class)
+            ->setConstructorArgs([$username])
+            ->setMethods(['getRandomNumber'])
+            ->getMock();
+
+        $client->method('getRandomNumber')->willReturn($expectedSalt);
+
+        $salt = $client->generateSalt();
+        $verifier = $client->generateVerifier($password);
+
+        $this->assertEquals($expectedSalt, $salt);
+        $this->assertEquals($expectedVerifier, $verifier);
+    }
+
+    /**
+     * @param $username
+     * @param $password
+     * @param $salt
+     * @param $expectedVerifier
+     *
      * @throws Exception
+     * @dataProvider dataProvider
      */
     public function testGenerateVerifierAgainstExistingData($username, $password, $salt, $expectedVerifier): void
     {