Skip to content

Commit 0e66b99

Browse files
committed
Resolve issues
Make service section background cover container, resolve SVG attribute errors, fix key error on projects and ignore eslint error on useEffect hook
1 parent 09a6945 commit 0e66b99

File tree

5 files changed

+16
-16
lines changed

5 files changed

+16
-16
lines changed

src/components/About.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export default function About() {
1111
background: "linear-gradient( rgba(0, 0, 0, " + darknessOverlayIntensity + "), rgba(0, 0, 0, " + darknessOverlayIntensity + ") ), url('/img/about/about.JPG')",
1212
backgroundAttachment: "fixed",
1313
backgroundPosition: "center",
14+
backgroundSize: "cover",
1415
minHeight: minHeight,
1516
zIndex: 3,
1617
color: "white",
@@ -46,4 +47,4 @@ export default function About() {
4647
</div>
4748
</>
4849
)
49-
}
50+
}

src/components/Navbar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default function Navbar(props: navInterface) {
3939
setCurrentSection(sections[0])
4040
}
4141
});
42-
}, [])
42+
}, []) // eslint-disable-line
4343
let cols = size.lg ? 6 : 2;
4444
let styles = {
4545
container: {
@@ -143,4 +143,4 @@ export default function Navbar(props: navInterface) {
143143
</div>
144144
</>
145145
)
146-
}
146+
}

src/components/Projects.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ export default function Projects() {
127127
<GridItem colSpan={4}>
128128
<Grid templateColumns={'repeat(' + cols + ', 1fr)'}
129129
templateRows={'repeat(' + rows + ', ' + rowHeight + 'px)'} gap={2}>
130-
{projects.map(project => <Project key={project.title} title={project.title ? project.title : undefined} images={project.images}/>)}
130+
{projects.map(project => <Project key={project.images[0].url} title={project.title ? project.title : undefined} images={project.images}/>)}
131131
</Grid>
132132
</GridItem>
133133
{size.lg && <GridItem/>}
@@ -178,4 +178,4 @@ function Project(props: projectInterface) {
178178
</GridItem>
179179
</>
180180
)
181-
}
181+
}

src/components/Services.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ export default function Services() {
5555
viewBox="0 0 24 24"
5656
fill="none"
5757
stroke="currentColor"
58-
stroke-width="1"
59-
stroke-linecap="round"
60-
stroke-linejoin="round"
58+
strokeWidth="1"
59+
strokeLinecap="round"
60+
strokeLinejoin="round"
6161
style={styles.icon}
6262
>
6363
<line x1="18" y1="2" x2="22" y2="6" />
@@ -78,9 +78,9 @@ export default function Services() {
7878
viewBox="0 0 24 24"
7979
fill="currentColor"
8080
stroke="white"
81-
stroke-width="1"
82-
stroke-linecap="round"
83-
stroke-linejoin="round"
81+
strokeWidth="1"
82+
strokeLinecap="round"
83+
strokeLinejoin="round"
8484
style={styles.icon}
8585
>
8686
<g>
@@ -103,9 +103,9 @@ export default function Services() {
103103
viewBox="0 0 24 24"
104104
fill="none"
105105
stroke="currentColor"
106-
stroke-width="1"
107-
stroke-linecap="round"
108-
stroke-linejoin="round"
106+
strokeWidth="1"
107+
strokeLinecap="round"
108+
strokeLinejoin="round"
109109
style={styles.icon}
110110
>
111111
<path d="M15 12l-8.5 8.5c-.83.83-2.17.83-3 0 0 0 0 0 0 0a2.12 2.12 0 010-3L12 9" />
@@ -126,4 +126,4 @@ export default function Services() {
126126
<div className="triangleDivBottom" />
127127
</>
128128
)
129-
}
129+
}

src/logo.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)