Skip to content

Commit 229c14c

Browse files
committed
Move the pull request guide to the developer guide
Motivation: CONTRIBUTING.md is useful only because it lets Github show a user the link to it so the user can check what information we need before submitting a bug report. However, Github does not do the same for a pull request submission form, and thus there's no reason to keep the information about how to submit a good pull request in CONTRIBUTING.md. Modification: Replace the section about issuing a pull request with the link to the official developer guide. Result: CONTRIBUTING.md is easier to maintain.
1 parent 90047b0 commit 229c14c

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

CONTRIBUTING.md

+2-7
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,7 @@ Linux infinity 3.10.32-1-lts #1 SMP Sun Feb 23 09:44:24 CET 2014 x86_64 GNU/Linu
4040
My system has IPv6 disabled.
4141
```
4242

43-
## How to submit a pull request
43+
## How to contribute your work
4444

45-
Pull requests should be targeted at the branch for the latest stable releases. If the pull request is for fixing a bug which also affects an old branch like `3.x`, we recommend you to submit another pull request for that branch, too.
45+
Before submitting a pull request or push a commit, please read [our developer guide](http://netty.io/wiki/developer-guide.html).
4646

47-
1. [Rebase](http://git-scm.com/book/en/Git-Branching-Rebasing) your changes against the upstream branch. Resolve any conflicts that arise.
48-
1. Write JUnit test cases if possible. If not sure about how to write one, ask to write one before it's merged.
49-
1. Run `mvn test` before the initial submission or the subsequent pushes, and ensure the build succeeds.
50-
51-
For more information on developing Netty, please refer to [the developer guide](http://netty.io/wiki/developer-guide.html).

0 commit comments

Comments
 (0)