Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't seem to enable pihole or dhcplss #975

Open
3 of 7 tasks
phynias opened this issue Jan 24, 2025 · 4 comments
Open
3 of 7 tasks

can't seem to enable pihole or dhcplss #975

phynias opened this issue Jan 24, 2025 · 4 comments
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress.

Comments

@phynias
Copy link

phynias commented Jan 24, 2025

Is there an existing issue for this?

The issue occurs in the following browsers. Select at least 2.

  • Firefox
  • Chrome
  • Edge
  • Safari (unsupported) - PRs welcome
  • N/A - This is an issue with the backend

Current Behavior

i am trying to enable PIHOLE and DHCPLSS
this is my docker-compose:

   environment:
      - APP_CONF_OVERRIDE={"PIHOLE_RUN":"schedule","PIHOLE_DB_PATH":"/etc/pihole/pihole-FTL.db","DHCPLSS_RUN":"schedule","DHCPLSS_RUN_SCHD":"*/5 * * * *","DHCPLSS_paths_to_check":"['/etc/pihole/dhcp.leases']"}

then in my logs i see this.

19:12:23 [Config] Number of Plugins to load: 16
19:12:23 [Config] Plugins to load: ['ARPSCAN', 'AVAHISCAN', 'INTRNT', 'NSLOOKUP', 'SMTP', 'CSVBCKP', 'CUSTPROP', 'DBCLNP', 'MAINT', 'NEWDEV', 'NTFPRCS', 'SETPWD', 'SYNC', 'UI', 'VNDRPDT', 'WORKFLOWS']
19:12:23 [Import Config] Skipped saving _KEEP_ for key : PIHOLE_RUN
19:12:23 [Import Config] Skipped saving _KEEP_ for key : PIHOLE_RUN
19:12:23 [Import Config] Skipped saving _KEEP_ for key : PIHOLE_RUN__metadata
19:12:23 [Import Config] Skipped saving _KEEP_ for key : PIHOLE_RUN__metadata
19:12:23 [Import Config] Skipped saving _KEEP_ for key : PIHOLE_DB_PATH
19:12:23 [Import Config] Skipped saving _KEEP_ for key : PIHOLE_DB_PATH
19:12:23 [Import Config] Skipped saving _KEEP_ for key : PIHOLE_DB_PATH__metadata
19:12:23 [Import Config] Skipped saving _KEEP_ for key : PIHOLE_DB_PATH__metadata
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_RUN
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_RUN
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_RUN__metadata
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_RUN__metadata
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_RUN_SCHD
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_RUN_SCHD
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_RUN_SCHD__metadata
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_RUN_SCHD__metadata
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_paths_to_check
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_paths_to_check
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_paths_to_check__metadata
19:12:23 [Import Config] Skipped saving _KEEP_ for key : DHCPLSS_paths_to_check__metadata

i tried to look where the KEEP was coming from but i can't find anything.

Expected Behavior

it loads up the plugins i specify.

Steps To Reproduce

No response

app.conf

docker-compose.yml

What installation are you running?

Dev (netalertx-dev)

app.log

No response

Debug enabled

  • I have read and followed the steps in the wiki link above and provided the required debug logs and the log section covers the time when the issue occurs.
@phynias phynias added the bug 🐛 Something isn't working label Jan 24, 2025
@jokob-sk
Copy link
Owner

Hi,

I think you have to also add these two to the LOADED_PLUGINS setting otherwise the app won't recognise these settings.

J

@jokob-sk jokob-sk added the Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. label Jan 24, 2025
@phynias
Copy link
Author

phynias commented Jan 24, 2025

added LOADED_PLUGINS to APP_CONF_OVERRIDE and same thing. the only way so far that i got it to work was manually editing the app.conf, adding the pihole and dhcplss config options there and restarting the container.

@jokob-sk
Copy link
Owner

jokob-sk commented Jan 24, 2025 via email

jokob-sk pushed a commit that referenced this issue Jan 24, 2025
@jokob-sk
Copy link
Owner

Hi,

So after debugging this the plugins need to be loaded before overridden settings to preventy a circular recursion. For that I created a custom compose variable LOADED_PLUGINS. If you add it to your docker-compose like below, the plugins should load.

 LOADED_PLUGINS=["DHCPLSS","PIHOLE","ASUSWRT","FREEBOX"]

You will still need to use the APP_CONF_OVERRIDE variable to set the actual settings.

This should be available in the next release. It would be great if you could test this. Can you please switch to the netalertx-dev docker image (backup everything at first or, ideally spin up a separate container with a separate db and config), in about 15 minutes (or after the last action finishes) from now?

Make sure you refresh your browser cache - and click the 🔄 refresh button in the top right corner.

Consider sharing the app on socials 🙂🙏

Thanks in advance,
j

@jokob-sk jokob-sk added the next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress.
Projects
None yet
Development

No branches or pull requests

2 participants