Skip to content

Commit d2c751a

Browse files
committed
Merge remote-tracking branch 'upstream/5.4-dev' into upmerges/2025-11-29
2 parents 4376849 + d7f79a9 commit d2c751a

File tree

16 files changed

+129
-98
lines changed

16 files changed

+129
-98
lines changed

README.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,21 @@ Do you want to improve Joomla?
7474
* Documentation for [Web designers](https://docs.joomla.org/Special:MyLanguage/Web_designers).
7575
* Provide a translation for Joomla: [Joomla Crowdin Project](https://joomla.crowdin.com/cms)
7676

77+
Which branch should my Pull Request target?
78+
--------------------
79+
Using a simple classification keeps the project **stable**, **transparent**, and **easy** for everyone to contribute.
80+
81+
| Type of change | What it means | Target branch |
82+
|---|---|---|
83+
| **Bug / Patch release** | The change fixes an actual error. The software crashes, produces the wrong result, or behaves contrary to its specification. It can be resolved without large‑scale refactoring or new functionality. | **[5.4-dev](https://github.com/joomla/joomla-cms/tree/5.4-dev)** (6.0-dev) **\*** |
84+
| **Feature / Minor release** | Anything that isn’t a strict bug – new behavior, refactoring, performance improvements, enhancements, UI tweaks, etc. These changes are bundled together for the next minor version. | **[6.1-dev](https://github.com/joomla/joomla-cms/tree/6.1-dev)** |
85+
86+
**\*** All bugs that already exist in version 5.4.x should be fixed in `5.4-dev`. Only bugs that are introduced for the first time in version 6.0.x should target the [`6.0-dev`](https://github.com/joomla/joomla-cms/tree/6.0-dev) branch.
87+
88+
A member of the maintainer or bug squad team confirms the classification and sets the appropriate labels when a PR is opened. If a PR is opened in the wrong branch, a maintainer will simply ask you to retarget it to the proper branch.
89+
90+
91+
7792
Copyright
7893
---------------------
7994
* (C) 2005 Open Source Matters, Inc. <https://www.joomla.org>

administrator/components/com_actionlogs/src/Controller/ActionlogsController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function exportLogs()
110110
$output = fopen("php://output", "w");
111111

112112
foreach ($rows as $row) {
113-
fputcsv($output, $row, $csvDelimiter);
113+
fputcsv($output, $row, $csvDelimiter, escape: "");
114114
}
115115

116116
fclose($output);

administrator/components/com_content/src/View/Articles/HtmlView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ protected function addToolbar()
203203
->buttonClass('text-center py-2 h3');
204204

205205
$cmd = "Joomla.submitbutton('articles.runTransition');";
206-
$messages = "{error: [Joomla.JText._('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST')]}";
206+
$messages = "{error: [Joomla.Text._('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST')]}";
207207
$alert = 'Joomla.renderMessages(' . $messages . ')';
208208
$cmd = 'if (document.adminForm.boxchecked.value == 0) { ' . $alert . ' } else { ' . $cmd . ' }';
209209

administrator/components/com_content/src/View/Featured/HtmlView.php

Lines changed: 0 additions & 28 deletions
This file was deleted.

administrator/components/com_menus/src/Helper/MenusHelper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public static function getLinkKey($request)
7272
if (\is_string($request)) {
7373
$args = [];
7474

75-
if (str_starts_with($request, 'index.php')) {
75+
if (str_starts_with($request, 'index.php?')) {
7676
parse_str(parse_url(htmlspecialchars_decode($request), PHP_URL_QUERY), $args);
7777
} else {
7878
parse_str($request, $args);

build/media_source/templates/administrator/atum/scss/blocks/_sidebar.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,8 +291,7 @@
291291
@if $enable-dark-mode {
292292
@include color-mode(dark) {
293293
.sidebar-wrapper {
294-
border: 1px solid rgba(255, 255, 255, .05);
295-
box-shadow: none;
294+
--atum-box-shadow: 1px 0 0 0 rgba(255, 255, 255, .05);
296295
.main-nav {
297296
.badge {
298297
color: map-get($atum-colors-dark, "btn-primary-color");

build/media_source/templates/administrator/atum/scss/pages/_com_cpanel.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,7 @@
193193
@include color-mode(dark) {
194194
.com_cpanel {
195195
.card {
196-
border: 1px solid rgba(255, 255, 255, .1);
197-
box-shadow: 1px 1px 2px rgba(0, 0, 0, .1);
196+
box-shadow: 0 0 0 1px rgba(255, 255, 255, .1), 1px 1px 2px rgba(0, 0, 0, .1);
198197

199198
.list-group-item:last-child {
200199
border-end-end-radius: var(--border-radius);

layouts/joomla/system/message.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
CMSApplication::MSG_NOTICE => 'info',
2828
CMSApplication::MSG_INFO => 'info',
2929
CMSApplication::MSG_DEBUG => 'info',
30-
'message' => 'success'
30+
CMSApplication::MSG_MESSAGE => 'success'
3131
];
3232

3333
// Load JavaScript message titles

libraries/src/Application/CMSApplicationInterface.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,22 @@ interface CMSApplicationInterface extends ExtensionManagerInterface, Configurati
9292
*/
9393
public const MSG_DEBUG = 'debug';
9494

95+
/**
96+
* Constant defining an enqueued message message
97+
*
98+
* @var string
99+
* @since __DEPLOY_VERSION__
100+
*/
101+
public const MSG_MESSAGE = 'message';
102+
103+
/**
104+
* Constant defining an enqueued success message
105+
*
106+
* @var string
107+
* @since __DEPLOY_VERSION__
108+
*/
109+
public const MSG_SUCCESS = 'success';
110+
95111
/**
96112
* Enqueue a system message.
97113
*

libraries/src/Application/ConsoleApplication.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,14 +209,15 @@ protected function doExecute(): int
209209
self::MSG_EMERGENCY => 'caution',
210210
self::MSG_ERROR => 'error',
211211
self::MSG_INFO => 'note',
212+
self::MSG_MESSAGE => 'success', // consistent with joomla.system.message layout
212213
self::MSG_NOTICE => 'note',
214+
self::MSG_SUCCESS => 'success',
213215
self::MSG_WARNING => 'warning',
214216
];
215217

216218
// Output any enqueued messages before the app exits
217219
foreach ($this->getMessageQueue() as $type => $messages) {
218220
$method = $methodMap[$type] ?? 'comment';
219-
220221
$style->$method($messages);
221222
}
222223

0 commit comments

Comments
 (0)