Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Duplicate query in debugbar is illegible when using Dark Mode #45084

Open
AkameOuO opened this issue Mar 7, 2025 · 5 comments
Open

[5.2] Duplicate query in debugbar is illegible when using Dark Mode #45084

AkameOuO opened this issue Mar 7, 2025 · 5 comments

Comments

@AkameOuO
Copy link
Contributor

AkameOuO commented Mar 7, 2025

Steps to reproduce the issue

  • Use dark mode and enable debug system
  • Visit any page with duplicate query
  • Open debugbar and choose queries tab

The upper one is duplicate and the other one is not.
Image

Expected result

All texts are legible.

Actual result

Duplicate query is illegible when using Dark Mode

System information (as much as possible)

Additional comments

Maybe use CSS variable?

@brianteeman
Copy link
Contributor

i believe this has been fixed already for joomla 5.3 with #44902

@AkameOuO
Copy link
Contributor Author

AkameOuO commented Mar 7, 2025

div.phpdebugbar-widgets-sqlqueries li.phpdebugbar-widgets-list-item.phpdebugbar-widgets-sql-duplicate {
background-color: #edeff0;
}
div.phpdebugbar-widgets-sqlqueries li.phpdebugbar-widgets-list-item.phpdebugbar-widgets-sql-duplicate:hover {
background-color: #ffc;
}

Sorry, but this is not included in that PR.

@richard67
Copy link
Member

Sorry, but this is not included in that PR.

@AkameOuO Could you test on a testing environment (i.e. not a production site) with a 5.3 nightly build if the issue also exists in 5.3? You can find the nightlies here: https://developer.joomla.org/nightly-builds.html. The issue might indeed be fixed with he PR which Brian had mentioned, just at a different place than where you expect it. If it still persists on 5.3, the issue might also be fixed by this PR which again updated the debug bar dependency: #45071 .

@AkameOuO
Copy link
Contributor Author

Image

Same in 5.3 nightly build

@brianteeman
Copy link
Contributor

there is a problem in the way we are including and overriding css with this external script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants