Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] [a11y] Login form text contrast #43067

Closed
C-Lodder opened this issue Mar 17, 2024 · 7 comments · May be fixed by #45117
Closed

[5.1] [a11y] Login form text contrast #43067

C-Lodder opened this issue Mar 17, 2024 · 7 comments · May be fixed by #45117
Labels
a11y Accessibility bug Dark Mode No Code Attached Yet

Comments

@C-Lodder
Copy link
Member

C-Lodder commented Mar 17, 2024 •
edited
Loading

Steps to reproduce the issue

The "Please fill in this field" do not meet the color contrast requirements in dark mode

I suppose this isn't just relevant to the form field, but all form validation.

Screenshot

image
@chmst chmst added a11y Accessibility bug Dark Mode labels Mar 17, 2024
@brianteeman
Copy link
Contributor

brianteeman commented Mar 17, 2024 •
edited
Loading

it is an easy fix but I dont understand why it has been created in the way it has been done so am reluctant to make an arbitrary change that may have consequences

The relevant code is in build\media_source\templates\administrator\atum\scss\_variables-dark.scss
$danger-dark: #c62a25; // contrast ratio: 5.59 with #fff text

@brianteeman
Copy link
Contributor

cc @coolcat-creations

@coolcat-creations
Copy link
Contributor

Will look into it. Unfortunately I also don't know why some things were done like they were done. Would be a good thing to refactor one day.

@brianteeman
Copy link
Contributor

My comment above was incorrect.

This error text is generated by the browser and can not be styled

@coolcat-creations
Copy link
Contributor

I will try to find a fix, sorry did not have the time yet

@brianteeman brianteeman mentioned this issue Mar 12, 2025
Open
4 tasks
@brianteeman
Copy link
Contributor

sorry I was completely wrong - i have created a pr for testing #45117

@Fedik Fedik linked a pull request Mar 12, 2025 that will close this issue
[5.3] [a11y] Dark Mode log in message #45117
Open
4 tasks
@alikon
Copy link
Contributor

alikon commented Mar 12, 2025

please test #45117

@alikon alikon closed this as completed Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Accessibility bug Dark Mode No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[5.3] [a11y] Dark Mode log in message brianteeman/joomla-cms
6 participants
@alikon @coolcat-creations @chmst @brianteeman @C-Lodder @joomla-cms-bot