Possible to avoid scroll-to-top when opening the dialog?

[searls]

Try as I might, whenever I'm in mobile and showModal() is called the page is scrolled to the top as the dialog comes up and then scrolled back down when the dialog is dismissed.

This is pretty jarring, especially if you set --hw-dialog-top-offset to a larger value so that the dialog doesn't take up the entire screen (I've had customers complain that they get thrown off by how it takes over the screen).

Any ideas?

[josefarias]

Hm, I think this may come from the vendored library we're using to lock body scrolling.

I've been meaning to replace that with our own implementation which hopefully can sidestep this.

Locking body scrolling when a modal is open is particularly hard in mobile Safari. So let's hope it's not a hard requirement.

[searls]

For what it's worth, I tried commenting out the body scroll lock / unlock calls and (while it indeed allowed scrolling and broke the UI), the modal zipped to the top of the page anyway. Googling around for the issue, it seems like people most often call out input focus as the culprit (I wonder, but haven't tested, if the timing of focus()'ing on the dialog input has something to do with it)

[josefarias]

@searls This should be fixed now in #215. If you get a moment, could I get you to try out that branch and validate the fix? Thanks!

[josefarias]

Actually, you might wanna hold off. I'll try to solve #215 (comment) before merging.