Upgrade solid cache to address NoMethodError #207
Merged
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidCache is raising errors in production following Rails 7.2 upgrade. NoMethodError - undefined method `model' for class SolidCache::Entry Same as reported here: rails/solid_cache#189 The error was not captured in specs because we have been using the NullStore for caching in tests. This error can be reproduced by setting SolidCacheStore in tests. I don’t want to enable this as the backend right now but may reconsider if we continue to see issues across upgrades.
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SolidCache is raising errors in production following Rails 7.2 upgrade.
Same as reported here:
rails/solid_cache#189
The error was not captured in specs because we have been using the NullStore for caching in tests.
This error can be reproduced by setting SolidCacheStore in tests. I don’t want to enable this as the backend right now but may reconsider if I continue to see issues across upgrades. One alternative idea would be to add a CI job that boots the app with production or development settings and checks for responses on root and some health check endpoints for sanity.