-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with same root directory name #1445
Comments
In the meeting we sumarized that the first issue is "ok" and will not need to be fixed in the next major version. Handled by throwing an error when directories have same name |
Partially addressed by #1495, thus not closed. |
I am not sure if I should continue the discussion in this issue or the other (#1849). My feature request regards addressing this.
what I would do is keeping the shortest common path to distinguish them, in this case the names wouldn't be |
I have implemented a proof of concept with a possible solution in this fork/branch:https://github.com/euberdeveloper/JPlag/tree/feature/allow-duplicate-submission-names |
If people use the same root directory two problems can occur.
Folder structur
executed with
jplag.jar files -new test/files
Here is the generated report:
results_A_C.zip
In the viewer we are not able to distinguish from wich files folder each submission came from. we should discuss wether this is an issue.
Folder structur
executed with
jplag.jar files -new test/files
Here is the generated report:
results_A_A.zip
Again, we cant tell from which folder each submission came from. This is defineatly an issue since they have the same name.
In addition only the files from one of the submissions are present in the files folder in the zip. Due to this matches cant be shown. This again is an issue.
All test were done with a build from the develop branch.
The text was updated successfully, but these errors were encountered: