Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Defaults Values $settings for \linfo\linfo #49

Open
KTP95 opened this issue Dec 12, 2016 · 2 comments
Open

Missing Defaults Values $settings for \linfo\linfo #49

KTP95 opened this issue Dec 12, 2016 · 2 comments

Comments

@KTP95
Copy link
Contributor

KTP95 commented Dec 12, 2016

$linfo = new \Linfo\Linfo; --> create problem without $setting vars,

Maybe possible do a defaults values and hard-include it in the class...

@KTP95 KTP95 changed the title Undefined index: show in linfo/linfo/src/Linfo/OS/Linux.php on line 653 Missing Defaults Values $settings for \linfo\linfo Dec 12, 2016
@jrgp
Copy link
Owner

jrgp commented Apr 23, 2017

That would be a good idea. Feel free to make a PR.

@Gummibeer
Copy link
Contributor

I'm not 100% sure about it - what would be enabled/disabled by default?
I think that this package handles sensitive data and cause of this the user should be 100% aware of what this package does on his machine.
So yes: it will help the lazy dev to use it - but it has also the risk that this package does things that the dev doesn't want it to do.

So just want to open a critical discussion, about pro-con, before doing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants