Rewrite package json bumper

Author: FagnerMartinsBrack

.eslintrc.json

@@ -5,7 +5,7 @@
   },
   "extends": "eslint:recommended",
   "parserOptions": {
-    "ecmaVersion": 6,
+    "ecmaVersion": 2017,
     "ecmaFeatures": {
       "impliedStrict": true
     }

package.json

@@ -10,8 +10,9 @@
   "author": "Fagner Brack",
   "license": "MIT",
   "scripts": {
-    "test": "eslint *.js \"src/**/*.js\" \"test/**/*.js\" && mocha --trace-warnings",
-    "test:watch": "eslint \"src/**/*.js\" \"test/**/*.js\" && mocha -w",
+    "lint": "eslint *.js \"src/**/*.js\" \"test/**/*.js\"",
+    "test": "mocha --trace-warnings",
+    "test:watch": "mocha -w",
     "release:test": "node release.js fake patch",
     "release": "node release.js patch"
   },
@@ -27,7 +28,6 @@
   "dependencies": {
     "app-root-path": "2.0.1",
     "bluebird": "3.5.1",
-    "json-update": "3.0.0",
     "nodegit": "0.20.2"
   },
   "engines": {

release.js

@@ -1,7 +1,7 @@
 const Promise = require("bluebird");
 const Git = require("nodegit");
 
-const bumpJSONFiles = require("./src/file/bump-json-files");
+const bumpPackageJSON = require("./src/file/bump-package-json");
 const gitCommit = require("./src/git/git-commit");
 const gitTag = require("./src/git/git-tag");
 const gitPushTag = require("./src/git/git-push-tag");
@@ -28,7 +28,7 @@ let localRepo;
 Promise.try(() => {
   console.log("Bumping package.json...");
   if (!isFakeRun) {
-    return bumpJSONFiles(targetBumpSpec, ["package.json"]);
+    return bumpPackageJSON(targetBumpSpec, "package.json");
   }
 }).then(() => {
   return Git.Repository.discover(".", 0, ".");

src/file/bump-json-files.js

@@ -0,0 +1,11 @@
+const root = require("app-root-path");
+const writeFile = require("util").promisify(require("fs").writeFile);
+const readFile = require("util").promisify(require("fs").readFile);
+
+const bumpVersion = require(root + "/src/bump-version");
+
+module.exports = async (bumpSpec, filePath) => {
+  const fileContentAsJSON = JSON.parse(await readFile(filePath, "UTF-8"));
+  fileContentAsJSON.version = bumpVersion(fileContentAsJSON.version, bumpSpec);
+  await writeFile(filePath, JSON.stringify(fileContentAsJSON));
+};

src/file/bump-package-json.js

@@ -1,33 +1,32 @@
-const root = require("app-root-path");
 const expect = require("chai").expect;
-const Promise = require("bluebird");
-const loadJSON = Promise.promisify(require("json-update").load);
+const readFile = require("util").promisify(require("fs").readFile);
+const writeFile = require("util").promisify(require("fs").writeFile);
+const unlink = require("util").promisify(require("fs").unlink);
 
-const bumpJSONFiles = require(root + "/src/file/bump-json-files");
-const createFileSync = require(root + "/test/dummy-data/create-file-sync");
+const bumpPackageJSON = require(require("app-root-path") + "/src/file/bump-package-json");
 
-describe("bump-json-files", function() {
+describe("Bump Package JSON", () => {
 
-  describe("Given a dummy file in JSON format", function() {
-    const targetFilename = "bump-minor.json";
-    let removeDummyJSONFileSync;
+  it("bumps the patch version in the package.json", async () => {
+    await writeFile("target-package.json", "{\"version\":\"0.0.0\"}");
+    await bumpPackageJSON("patch", "target-package.json");
+    const targetFileContent = await readFile("target-package.json", "UTF-8");
+    expect(targetFileContent).to.equal("{\"version\":\"0.0.1\"}");
+    await unlink("target-package.json");
 
-    beforeEach(function() {
-      removeDummyJSONFileSync = createFileSync(targetFilename, JSON.stringify({
-        version: "0.0.0"
-      }));
-    });
-
-    afterEach(function() {
-      removeDummyJSONFileSync();
-    });
+    await writeFile("another-target-package.json", "{\"version\":\"0.0.0\"}");
+    await bumpPackageJSON("patch", "another-target-package.json");
+    const anotherTargetFileContent = await readFile("another-target-package.json", "UTF-8");
+    expect(anotherTargetFileContent).to.equal("{\"version\":\"0.0.1\"}");
+    await unlink("another-target-package.json");
+  });
 
-    it("should bump the 'minor' version attribute", function() {
-      return bumpJSONFiles("minor", [targetFilename]).then(function() {
-        return loadJSON(targetFilename);
-      }).then(function(targetFile) {
-        expect(targetFile).to.have.property("version", "0.1.0");
-      });
-    });
+  it("keeps existing properties intact", async () => {
+    await writeFile("target-package.json", "{\"existing\":1,\"version\":\"0.0.0\"}");
+    await bumpPackageJSON("patch", "target-package.json");
+    const bumpedFile = await readFile("target-package.json", "UTF-8");
+    expect(bumpedFile).to.equal("{\"existing\":1,\"version\":\"0.0.1\"}");
+    await unlink("target-package.json");
   });
+
 });