Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 doesn't work as well as the Legacy #134

Open
uniquekaiser opened this issue Apr 5, 2015 · 4 comments
Open

Version 2 doesn't work as well as the Legacy #134

uniquekaiser opened this issue Apr 5, 2015 · 4 comments

Comments

@uniquekaiser
Copy link

Hi!

First of all, great work!

I was using Fixmyjs a lot for a project that uses auto-generated JavaScript. the Legacy mode was doing a great job for me. I had the project on a standstill and decided to come back to it; i tried the new version but I'm not getting very good results :(

Is there anyway to access the Legacy version?

Thanks!

@goatslacker
Copy link
Member

Hey, thanks for the feedback. What do you miss most from legacy mode? What was legacy fixing before that you can't fix now?

@uniquekaiser
Copy link
Author

Hi, thank you for the quick reply! Well, as i told you, the javaScript is coming from an auto generated source... so what I can say is that is that i would run the mode several times, and then checked the code in jshint.com until i would get a low level of warning. After cthe code it would be greatly optimized in speed!

Now, I'm trying the same approach, but in jshint.com it doesn't even get to a point it checke the whole code due to a large amount of Errors/warnings present in the. Things like missing semicolons are not being fixed, among other things i would imagine...

i'm a doing something wrong?

@goatslacker
Copy link
Member

Besides missing semicolons are there other errors you are seeing that should be fixed?

@uniquekaiser
Copy link
Author

Can't get pass these errors:

Use '===' to compare with 'undefined'.
Use '===' to compare with '0'.
Use '===' to compare with ''.
Use '===' to compare with 'null'.
Missing semicolon.
Unexpected use of '>>'.
Expected a 'break' statement before 'default

The repeat over 52 times and JSHint stops scanning: Too many errors. (10% scanned).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants