Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Enhancement: Automate PR body validation with issue link and placeholder questions #1123

Open
aialok opened this issue Nov 18, 2024 · 8 comments · May be fixed by #1233
Open

✨ Enhancement: Automate PR body validation with issue link and placeholder questions #1123

aialok opened this issue Nov 18, 2024 · 8 comments · May be fixed by #1233
Assignees
@abhayymishraa
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@aialok
Copy link
Member

aialok commented Nov 18, 2024

Is your feature request related to a problem? Please describe

Pull requests soketimes lack essential details, such as links to related issues or answers to key placeholder questions, which can hinder review and tracking. Ensuring that PRs consistently provide this information would improve clarity and streamline the review process.

Describe the solution you'd like

Create a GitHub Actions workflow that automatically checks pull requests for links to relevant issues or discussions, as well as for answers to placeholder questions (e.g., "What does this PR address?" or "Are there any breaking changes?"). If any required information is missing, the workflow should post a comment prompting the author to provide the missing details.

Describe alternatives you've considered

No response

Additional context

Discussion : https://json-schema.slack.com/archives/C080VJMF25Q/p1731687107477929

Are you working on this?

Yes
@aialok aialok added ✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Triage This is the initial status for an issue that requires triage. labels Nov 18, 2024
@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Triage This is the initial status for an issue that requires triage. labels Nov 23, 2024
@benjagm
Copy link
Collaborator

benjagm commented Nov 23, 2024

Sounds good. thanks @aialok !! go ahead.

@abhayymishraa
Copy link
Contributor

@DhairyaMajmudar can i work on it

@DhairyaMajmudar
Copy link
Member

@aialok if its okay shall I assign this issue to @abhayymishraa ?

@aialok
Copy link
Member Author

aialok commented Dec 31, 2024 •
edited
Loading

@aialok if its okay shall I assign this issue to @abhayymishraa ?

Yes, please go ahead.
I have some other priority for now.

@DhairyaMajmudar
Copy link
Member

Yes, please go ahead. I have some other priority for now.

Thank you Alok, looking forward for your PR @abhayymishraa

@abhayymishraa abhayymishraa linked a pull request Jan 2, 2025 that will close this issue
Open
@abhayymishraa
Copy link
Contributor

@DhairyaMajmudar @aialok
I have made all the changes mentioned in the issue and tested everything thoroughly. I look forward to any suggestions for improvement

@29deepanshutyagi
Copy link
Contributor

i want to work on this issue ,, as currently no one had this issue assigned, so please assign me @DhairyaMajmudar

@abhayymishraa
Copy link
Contributor

i had already made a pr @29deepanshutyagi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhayymishraa abhayymishraa

Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
Website Contributor Board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Validation Workflow for Pull Request Content abhayymishraa/website
5 participants
@benjagm @aialok @29deepanshutyagi @DhairyaMajmudar @abhayymishraa