Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Two JavaScript labels for filter on Tools page #1443

Open
Vishv0407 opened this issue Mar 2, 2025 · 14 comments · May be fixed by #1516
Open

🐛 Bug: Two JavaScript labels for filter on Tools page #1443

Vishv0407 opened this issue Mar 2, 2025 · 14 comments · May be fixed by #1516
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. javascript Pull requests that update Javascript code Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@Vishv0407
Copy link
Contributor

Describe the bug

On the tools page, on the left side, there is a dropdown for 'Language.' In that dropdown, there are two labels pointing to the same thing: 'JavaScript' and 'Javascript.' The only difference is the capitalization of 's' and 'S.

Steps To Reproduce

  1. Go to tools page(https://json-schema.org/tools).
  2. Click on 'Language' dropdown.
  3. Scroll down to the names starting from letter 'J'.
  4. There you can see 'Javascript' and 'Javascript'.

Expected Behavior

There should be only one label 'JavaScript'.

Screenshots

Image

Device Information [optional]

- OS: Ubantu 24.04
- Browser: Firefox
- version: 135.0.1 (64-bit)

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

Yes

@Vishv0407 Vishv0407 added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Mar 2, 2025
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Mar 2, 2025
@Vishv0407
Copy link
Contributor Author

@benjagm @DhairyaMajmudar, can you please assign this issue to me, so I can make a PR?.

@Vishv0407
Copy link
Contributor Author

Furthermore, I see another similar issue with 'macOS' and 'MacOS'.

here is the screenshot:
Image

@idanidan29
Copy link
Contributor

This issue occurs with TypeScript as well.

Image

@benjagm
Copy link
Collaborator

benjagm commented Mar 2, 2025

To Fix this we need:

@Vishv0407
Copy link
Contributor Author

okay @benjagm, I will make these changes and make a PR soon. Can you please assign this to me?

@benjagm
Copy link
Collaborator

benjagm commented Mar 4, 2025

go ahead @Vishv0407

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Triage This is the initial status for an issue that requires triage. labels Mar 4, 2025
@Vishv0407
Copy link
Contributor Author

Hello @benjagm,

Could you please confirm if I have the correct understanding of the process for adding a tool to the Tools page?

  1. Go to the Tools page.
  2. Click on "Adding your tool".
  3. This opens a new issue using a predefined template, where I need to provide all the necessary details. Once the issue is created, what happens next?

From what I observe, the assignee of the issue manually adds the provided details to the tooling-data.yaml file.

Am I correct in understanding this process?

Thanks!

@DhairyaMajmudar
Copy link
Member

Issue will be resolved in PR: #1513

@DhairyaMajmudar
Copy link
Member

However their's still left the part suggested in #1443 (comment)

  • Make sure that this github action forces the case sensitive matching when evaluating the json instance against the schema. I am not sure how those occurrences ended up merged. It would be great to find what was the PR merging this and why the github action didn't avoid it.

@Vishv0407 pls. have a look into that point.

@Vishv0407
Copy link
Contributor Author

Vishv0407 commented Mar 13, 2025

@DhairyaMajmudar I have proposed my solution idea in #1512(PR). Please review that PR and provide your feedback.

Just to clarify #1513 is only for changing words in tooling-data.yaml which solves this issue #1443.

@DhairyaMajmudar
Copy link
Member

Your PR #1513 consists of the same changes that were done in PR #1512, that's why it's no meaning reviewing it again

FYI: https://github.com/json-schema-org/website/pull/1513/files

@Vishv0407
Copy link
Contributor Author

Vishv0407 commented Mar 13, 2025

@DhairyaMajmudar my apologies for confusion. I have added a comment in #1513 for a solution and not changed files as per that, I will wait for your confirmation to add that code in the GitHub workflow.

@DhairyaMajmudar
Copy link
Member

No worries @Vishv0407 , it seems like by mistake you committed the code changes to the same PR, it's fine as the PR size is small but take in the future while working with large PR sizes.

What can you do now?

The PR #1513 just requires a minor code change, rest its all done.
As I mentioned here there's still left some work to be done for this issue #1443, for that you can open a separate PR.

@Vishv0407
Copy link
Contributor Author

@DhairyaMajmudar I have updated the PR #1512 and created a new separate PR #1516 which solving below mentioned point.

  • Make sure that this github action forces the case sensitive matching when evaluating the json instance against the schema. I am not sure how those occurrences ended up merged. It would be great to find what was the PR merging this and why the github action didn't avoid it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. javascript Pull requests that update Javascript code Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
4 participants