-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug: Two JavaScript labels for filter on Tools page #1443
Comments
@benjagm @DhairyaMajmudar, can you please assign this issue to me, so I can make a PR?. |
To Fix this we need:
|
okay @benjagm, I will make these changes and make a PR soon. Can you please assign this to me? |
go ahead @Vishv0407 |
Hello @benjagm, Could you please confirm if I have the correct understanding of the process for adding a tool to the Tools page?
From what I observe, the assignee of the issue manually adds the provided details to the tooling-data.yaml file. Am I correct in understanding this process? Thanks! |
Issue will be resolved in PR: #1513 |
However their's still left the part suggested in #1443 (comment)
@Vishv0407 pls. have a look into that point. |
@DhairyaMajmudar I have proposed my solution idea in #1512(PR). Please review that PR and provide your feedback. Just to clarify #1513 is only for changing words in tooling-data.yaml which solves this issue #1443. |
Your PR #1513 consists of the same changes that were done in PR #1512, that's why it's no meaning reviewing it again FYI: https://github.com/json-schema-org/website/pull/1513/files |
@DhairyaMajmudar my apologies for confusion. I have added a comment in #1513 for a solution and not changed files as per that, I will wait for your confirmation to add that code in the GitHub workflow. |
No worries @Vishv0407 , it seems like by mistake you committed the code changes to the same PR, it's fine as the PR size is small but take in the future while working with large PR sizes. What can you do now? The PR #1513 just requires a minor code change, rest its all done. |
@DhairyaMajmudar I have updated the PR #1512 and created a new separate PR #1516 which solving below mentioned point.
|
Describe the bug
On the tools page, on the left side, there is a dropdown for 'Language.' In that dropdown, there are two labels pointing to the same thing: 'JavaScript' and 'Javascript.' The only difference is the capitalization of 's' and 'S.
Steps To Reproduce
Expected Behavior
There should be only one label 'JavaScript'.
Screenshots
Device Information [optional]
Are you working on this issue?
Yes
Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)
Yes
The text was updated successfully, but these errors were encountered: